From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752538AbdGCGWg (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Jul 2017 02:22:36 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:58864 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750961AbdGCGWf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Jul 2017 02:22:35 -0400
Date: Mon, 3 Jul 2017 08:22:29 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Lynn Lei <lynnl.wit@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: refactor method and fix potential type
 inconsistence
Message-ID: <20170703062229.GD13523@kroah.com>
References: <20170702142335.GA9915@lynnl.wit>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170702142335.GA9915@lynnl.wit>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 02, 2017 at 10:27:40PM +0800, Lynn Lei wrote:
> make reg variable typed `u32' not `unsigned int'
> this can fix potential type inconsistence in some platforms

It can?  What platform?

> 
> refactor swPanelPowerSequence() make the code less redundant
> 
> a early check for disp to skip unnecessary delay

Only do one thing per patch please.

thanks,

greg k-h