Re: [PATCH v3 2/2] i2c: Add Spreadtrum I2C controller driver

Chunyan Zhang
2017-07-03T09:30:01Z

Hi Baolin,

On 26 June 2017 at 18:28, Baolin Wang <baolin.wang@spreadtrum.com> wrote:
> This patch adds the I2C controller driver for Spreadtrum SC9860 platform.
>
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
> Changes since v2:
> - Remove some redundant comments and parens.
> - Define macros instead of magic number.
> - Add some comments to explain clock formula.
> - Change of_clk_get_by_name() to devm_clk_get().
> - Deal with other frequency.
> - Change register definiton to low case.
> - Change is_last_msg to boolean.
> - Other optimization.
>
> Changes sice v1:
> - Power on I2C device in probe().
> - Remove redundant macros and usb __maybe_unused.
> - Remove redundant 'of_match_ptr'.
> - Modify return values and check the return value for 'clk_prepare_enable'.
> ---
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-sprd.c | 683 +++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 691 insertions(+)
> create mode 100644 drivers/i2c/busses/i2c-sprd.c
>

[snip]

> diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
> new file mode 100644
> index 0000000..a070f61
> --- /dev/null
> +++ b/drivers/i2c/busses/i2c-sprd.c
> @@ -0,0 +1,683 @@
> +/*
> + * Copyright (C) 2017 Spreadtrum Communications Inc.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

According to RobH's comments [1], we're switching to use
SPDX-License-Identifier tag instead, like [2].

[1] http://lkml.iu.edu/hypermail/linux/kernel/1702.2/05122.html
[2] http://elixir.free-electrons.com/linux/v4.12/source/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts#L6

Thanks,
Chunyan