Re: [PATCH 4.4 057/101] net: sctp: fix array overrun read on sctp_timer_tbl

Ben Hutchings
2017-07-04T18:48:50Z

On Mon, 2017-07-03 at 15:34 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Colin Ian King <colin.king@canonical.com>
>
>
> [ Upstream commit 0e73fc9a56f22f2eec4d2b2910c649f7af67b74d ]
>
> The comparison on the timeout can lead to an array overrun
> read on sctp_timer_tbl because of an off-by-one error.
[...]

The off-by-one error was only introduced in 4.11 by:

commit 7b9438de0cd4b46a6914416bfede6cf839cd9e68
Author: Xin Long <lucien.xin@gmail.com>
Date: Wed Jan 18 00:44:43 2017 +0800

sctp: add stream reconf timer

So it is harmless but also useless to apply this to 4.4 and 4.9.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.