From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbdGDHWy (ORCPT ); Tue, 4 Jul 2017 03:22:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34024 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbdGDHWw (ORCPT ); Tue, 4 Jul 2017 03:22:52 -0400 Date: Tue, 4 Jul 2017 09:22:51 +0200 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: Loc Ho , Aleksey Makarov , Jon Mason , Jon Masters , "Rafael J. Wysocki" , Len Brown , Robert Moore , Lv , ACPI Devel Maling List , Linux Kernel Mailing List , "devel@acpica.org" , Broadcom Kernel List , patches@apm.com Subject: Re: [PATCH v2 1/2] ACPI: SPCR: Use access width to determine mmio usage Message-ID: <20170704072251.GA17867@kroah.com> References: <1499117589-4829-1-git-send-email-lho@apm.com> <1499117589-4829-2-git-send-email-lho@apm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 03, 2017 at 11:44:30PM +0200, Rafael J. Wysocki wrote: > On Mon, Jul 3, 2017 at 11:33 PM, Loc Ho wrote: > > The current SPCR code does not check the access width of the mmio, and > > uses a default of 8bit register accesses. This prevents devices that > > only do 16 or 32bit register accesses from working. By simply checking > > this field and setting the mmio string appropriately, this issue can be > > corrected. To prevent any legacy issues, the code will default to 8bit > > accesses if the value is anything but 16 or 32. > > > > Signed-off-by: Loc Ho > > [Re-send as single patch set] > > Signed-off-by: Jon Mason > > Greg, Aleksey, any objections here? > > If not, I'll route this through the ACPI tree. No objections from me for either of these patches: Acked-by: Greg Kroah-Hartman