From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Cliff Whickman <cpw@sgi.com>, Robin Holt <robinmholt@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()
Date: Tue, 4 Jul 2017 16:55:26 -0500 [thread overview]
Message-ID: <20170704215526.GA10933@embeddedgus> (raw)
Remove unnecessary static on local variable _ret_.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.
This issue was detected using Coccinelle and the following semantic patch:
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>
@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
T x@p;
... when != x
when strict
?x = e;
In the following log you can see the difference in the code size.
This log is the output of the size command, before and after the
code change:
before:
text data bss dec hex filename
25457 3056 448 28961 7121 drivers/misc/sgi-xp/xpc_uv.o
after:
text data bss dec hex filename
25405 3000 384 28789 7075 drivers/misc/sgi-xp/xpc_uv.o
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/misc/sgi-xp/xpc_uv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 340b44d..6581eba 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -1151,7 +1151,7 @@ xpc_allocate_recv_msg_slot_uv(struct xpc_channel *ch)
static enum xp_retval
xpc_setup_msg_structures_uv(struct xpc_channel *ch)
{
- static enum xp_retval ret;
+ enum xp_retval ret;
struct xpc_channel_uv *ch_uv = &ch->sn.uv;
DBUG_ON(ch->flags & XPC_C_SETUP);
--
2.5.0
next reply other threads:[~2017-07-04 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 21:55 Gustavo A. R. Silva [this message]
2017-07-11 9:19 ` [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv() Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704215526.GA10933@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robinmholt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox