From: Alessandro Rubini <rubini@gnudd.com>
To: riehecky@fnal.gov
Cc: linux-kernel@vger.kernel.org, drivers_other@kernel-bugs.osdl.org,
gregkh@linuxfoundation.org, federico.vaga@cern.ch
Subject: Re: [PATCH 0/5] Update kernel to latest FMC bus release
Date: Wed, 5 Jul 2017 12:27:13 +0200 [thread overview]
Message-ID: <20170705102713.GA20907@mail.gnudd.com> (raw)
In-Reply-To: <cover.1498838809.git.riehecky@fnal.gov>
Hello.
Thank you Pat for taking care of these patches.
> Federico Vaga (5):
> drivers/fmc: remove unused variable
> drivers/fmc: hide fmc operations behind helpers
> drivers/fmc: The only way to dump the SDB is from debugfs
> drivers/fmc: change registration prototype
> drivers/fmc: carrier can program FPGA on registration
The main problem with your patches, as submitted, is that they miss
the "From:" line to attribute Federico as author. Then I think you
might add your own "Tested-by:".
I want to ack them but I'd love to run them first to have a second
check. I should definitely manage it in a pair of days
more. Meanwhile, if you want to post V2 with the fixes above that
would be great. If needed, you can write me offlist.
thankyou for your submission and your patience
/alessandro
next prev parent reply other threads:[~2017-07-05 10:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:15 [PATCH 0/5] Update kernel to latest FMC bus release Pat Riehecky
2017-06-30 16:15 ` [PATCH 1/5] drivers/fmc: remove unused variable Pat Riehecky
2017-06-30 16:15 ` [PATCH 2/5] drivers/fmc: hide fmc operations behind helpers Pat Riehecky
2017-06-30 16:15 ` [PATCH 3/5] drivers/fmc: The only way to dump the SDB is from debugfs Pat Riehecky
2017-06-30 16:15 ` [PATCH 4/5] drivers/fmc: change registration prototype Pat Riehecky
2017-06-30 16:15 ` [PATCH 5/5] drivers/fmc: carrier can program FPGA on registration Pat Riehecky
2017-07-05 10:27 ` Alessandro Rubini [this message]
2017-07-05 14:22 ` [PATCH v2 00/05] Update kernel to latest FMC bus release Pat Riehecky
2017-07-05 14:22 ` [PATCH v2 01/05] drivers/fmc: remove unused variable Pat Riehecky
2017-07-17 14:29 ` Greg KH
2017-07-05 14:22 ` [PATCH v2 02/05] drivers/fmc: hide fmc operations behind helpers Pat Riehecky
2017-07-05 14:22 ` [PATCH v2 03/05] drivers/fmc: The only way to dump the SDB is from debugfs Pat Riehecky
2017-07-05 14:22 ` [PATCH v2 04/05] drivers/fmc: change registration prototype Pat Riehecky
2017-07-05 14:22 ` [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on registration Pat Riehecky
2017-07-17 14:30 ` Greg KH
2017-07-17 14:33 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705102713.GA20907@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=drivers_other@kernel-bugs.osdl.org \
--cc=federico.vaga@cern.ch \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riehecky@fnal.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox