public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Venture <venture@google.com>
To: venture@google.com, joel@jms.id.au, roblip@gmail.com,
	gregkh@linuxfoundation.org
Cc: raltherr@google.com, arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: [PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat
Date: Wed,  5 Jul 2017 12:04:16 -0700	[thread overview]
Message-ID: <20170705190416.51691-1-venture@google.com> (raw)

This driver can be used on the aspeed ast2400 with minor
modifications.

Tested: ast2400 on quanta-q71l

Signed-off-by: Patrick Venture <venture@google.com>
---
v2: added aspeed-g5 area because ast2400 doesn't use those bits.
    also updated commit message.
---
 drivers/misc/aspeed-lpc-snoop.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c
index 593905565b74..83f9a9e5a7cf 100644
--- a/drivers/misc/aspeed-lpc-snoop.c
+++ b/drivers/misc/aspeed-lpc-snoop.c
@@ -155,8 +155,9 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
 	regmap_update_bits(lpc_snoop->regmap, HICR5, hicr5_en, hicr5_en);
 	regmap_update_bits(lpc_snoop->regmap, SNPWADR, snpwadr_mask,
 			   lpc_port << snpwadr_shift);
+#ifdef CONFIG_MACH_ASPEED_G5
 	regmap_update_bits(lpc_snoop->regmap, HICRB, hicrb_en, hicrb_en);
-
+#endif
 	return rc;
 }
 
@@ -241,6 +242,7 @@ static int aspeed_lpc_snoop_remove(struct platform_device *pdev)
 
 static const struct of_device_id aspeed_lpc_snoop_match[] = {
 	{ .compatible = "aspeed,ast2500-lpc-snoop" },
+	{ .compatible = "aspeed,ast2400-lpc-snoop" },
 	{ },
 };
 
-- 
2.13.2.725.g09c95d1e9-goog

             reply	other threads:[~2017-07-05 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 19:04 Patrick Venture [this message]
2017-07-05 19:43 ` [PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat Arnd Bergmann
2017-07-05 19:47   ` Patrick Venture

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705190416.51691-1-venture@google.com \
    --to=venture@google.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raltherr@google.com \
    --cc=roblip@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox