From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Julian Wiedmann <jwi@linux.vnet.ibm.com>,
Ursula Braun <ubraun@linux.vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/18] drivers: s390: Move static and inline before return type
Date: Thu, 6 Jul 2017 12:29:40 +0200 [thread overview]
Message-ID: <20170706102940.GG3217@osiris> (raw)
In-Reply-To: <3f980cd89084ae09716353aba3171e4b3815e690.1499284835.git.joe@perches.com>
On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote:
> Make the code like the rest of the kernel.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/s390/net/ctcm_main.c | 2 +-
> drivers/s390/net/qeth_l3_main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 3062cde33a3d..8975cd321390 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -2408,7 +2408,7 @@ static int qeth_l3_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
> return rc;
> }
>
> -int inline qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
> +inline int qeth_l3_get_cast_type(struct qeth_card *card, struct sk_buff *skb)
> {
Actually the function could be made static, and "inline" should be removed,
considering the large function body.
next prev parent reply other threads:[~2017-07-06 10:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 20:02 [PATCH 00/18] treewide: Move storage class before return type Joe Perches
2017-07-05 20:02 ` [PATCH 01/18] checkpatch: improve the STORAGE_CLASS test Joe Perches
2017-07-05 20:02 ` [PATCH 02/18] ARM: KVM: Move asmlinkage before type Joe Perches
2017-07-05 20:02 ` [PATCH 03/18] ARM: HP Jornada 7XX: Move inline before return type Joe Perches
2017-07-05 20:02 ` [PATCH 04/18] CRIS: gpio: " Joe Perches
2017-07-05 20:02 ` [PATCH 05/18] FRV: tlbflush: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 06/18] ia64: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 07/18] ia64: sn: pci: Move inline before type Joe Perches
2017-07-05 20:02 ` [PATCH 08/18] m68k: coldfire: Move inline before return type Joe Perches
2017-07-06 0:45 ` Greg Ungerer
2017-07-05 20:02 ` [PATCH 09/18] MIPS: SMP: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 10/18] sh: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 11/18] x86/efi: Move asmlinkage " Joe Perches
2017-07-05 20:02 ` [PATCH 12/18] drivers: s390: Move static and inline " Joe Perches
2017-07-06 10:29 ` Heiko Carstens [this message]
2017-07-06 10:57 ` Joe Perches
2017-07-06 12:25 ` Heiko Carstens
2017-07-06 18:04 ` Julian Wiedmann
2017-07-05 20:02 ` [PATCH 13/18] drivers: tty: serial: Move " Joe Perches
2017-07-05 20:02 ` [PATCH 14/18] USB: serial: safe_serial: Move __inline__ " Joe Perches
2017-07-05 20:02 ` [PATCH 15/18] video: fbdev: intelfb: Move inline " Joe Perches
2017-07-05 20:02 ` [PATCH 16/18] video: fbdev: omap: " Joe Perches
2017-07-05 20:02 ` [PATCH 17/18] ARM: samsung: usb-ohci: " Joe Perches
2017-07-05 20:02 ` [PATCH 18/18] ALSA: opl4: " Joe Perches
2017-07-05 20:30 ` Clemens Ladisch
2017-07-06 7:24 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706102940.GG3217@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox