* [PATCH] drm/tegra: sor: add NULL check on of_match_device() return value
@ 2017-07-07 6:11 Gustavo A. R. Silva
2017-07-07 7:42 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-07 6:11 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Jonathan Hunter
Cc: dri-devel, linux-tegra, linux-kernel, Gustavo A. R. Silva
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.
In case of NULL print error message and return.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/gpu/drm/tegra/sor.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index a8f5289..ca3d9b1 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -2538,6 +2538,10 @@ static int tegra_sor_probe(struct platform_device *pdev)
int err;
match = of_match_device(tegra_sor_of_match, &pdev->dev);
+ if (!match) {
+ dev_err(&pdev->dev, "failed to match device\n");
+ return -ENODEV;
+ }
sor = devm_kzalloc(&pdev->dev, sizeof(*sor), GFP_KERNEL);
if (!sor)
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: sor: add NULL check on of_match_device() return value
2017-07-07 6:11 [PATCH] drm/tegra: sor: add NULL check on of_match_device() return value Gustavo A. R. Silva
@ 2017-07-07 7:42 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2017-07-07 7:42 UTC (permalink / raw)
To: Gustavo A. R. Silva, Thierry Reding, David Airlie
Cc: dri-devel, linux-tegra, linux-kernel
On 07/07/17 07:11, Gustavo A. R. Silva wrote:
> Check return value from call to of_match_device()
> in order to prevent a NULL pointer dereference.
>
> In case of NULL print error message and return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/gpu/drm/tegra/sor.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index a8f5289..ca3d9b1 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -2538,6 +2538,10 @@ static int tegra_sor_probe(struct platform_device *pdev)
> int err;
>
> match = of_match_device(tegra_sor_of_match, &pdev->dev);
> + if (!match) {
> + dev_err(&pdev->dev, "failed to match device\n");
> + return -ENODEV;
> + }
Given that Tegra always uses device-tree, I believe that this cannot
happen and so this additional check is not needed.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-07 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-07 6:11 [PATCH] drm/tegra: sor: add NULL check on of_match_device() return value Gustavo A. R. Silva
2017-07-07 7:42 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox