From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbdGGAnA (ORCPT ); Thu, 6 Jul 2017 20:43:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:50462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752351AbdGGAm7 (ORCPT ); Thu, 6 Jul 2017 20:42:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C2A921C9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Fri, 7 Jul 2017 09:42:55 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, Stafford Horne Subject: Re: [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -" Message-Id: <20170707094255.5d14981b1a48218bebbe55a8@kernel.org> In-Reply-To: <20170706095026.5442dbc4@gandalf.local.home> References: <149933198569.8910.14570277134817357038.stgit@devbox> <149933224814.8910.6251941927192633354.stgit@devbox> <20170706095026.5442dbc4@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jul 2017 09:50:26 -0400 Steven Rostedt wrote: > On Thu, 6 Jul 2017 18:10:58 +0900 > Masami Hiramatsu wrote: > > > @@ -255,12 +262,18 @@ __run_test() { # testfile > > # Run one test case > > run_test() { # testfile > > local testname=`basename $1` > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX` > > + if [ ! -z "$LOG_FILE" ] ; then > > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX` > > + else > > + local testlog=`/proc/self/fd/1` > > As Stafford mentioned. I don't think you want backticks here. Oops, right! -- Masami Hiramatsu