From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448AbdGGMUV (ORCPT ); Fri, 7 Jul 2017 08:20:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:41518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbdGGMUU (ORCPT ); Fri, 7 Jul 2017 08:20:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A1F322B52 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 7 Jul 2017 09:20:16 -0300 From: Arnaldo Carvalho de Melo To: "Jin, Yao" Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH] perf report: Fix broken arrow at row 0 in annotate view Message-ID: <20170707122016.GN27350@kernel.org> References: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 07, 2017 at 01:11:42PM +0800, Jin, Yao escreveu: > Hi Arnaldo, > > Could this patch be merged? I'll test this one and the v4 fused ins series, thanks for following this up! - Arnaldo > Otherwise the jump arrow is broken when it's displayed at the row 0 in > annotate view. > > Thanks > > Jin Yao > > On 6/8/2017 2:01 PM, Jin Yao wrote: > > When the jump instruction is displayed at the row 0 in annotate view, > > the arrow is broken. An example: > > > > 16.86 │ ┌──je 82 > > 0.01 │ movsd (%rsp),%xmm0 > > │ movsd 0x8(%rsp),%xmm4 > > │ movsd 0x8(%rsp),%xmm1 > > │ movsd (%rsp),%xmm3 > > │ divsd %xmm4,%xmm0 > > │ divsd %xmm3,%xmm1 > > │ movsd (%rsp),%xmm2 > > │ addsd %xmm1,%xmm0 > > │ addsd %xmm2,%xmm0 > > │ movsd %xmm0,(%rsp) > > │82: sub $0x1,%ebx > > 83.03 │ ↑ jne 38 > > │ add $0x10,%rsp > > │ xor %eax,%eax > > │ pop %rbx > > │ ← retq > > > > The patch increments the row number before checking with 0. > > > > Signed-off-by: Jin Yao > > --- > > tools/perf/ui/browser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c > > index a4d3762..83874b0 100644 > > --- a/tools/perf/ui/browser.c > > +++ b/tools/perf/ui/browser.c > > @@ -704,7 +704,7 @@ static void __ui_browser__line_arrow_down(struct ui_browser *browser, > > ui_browser__gotorc(browser, row, column + 1); > > SLsmg_draw_hline(2); > > - if (row++ == 0) > > + if (++row == 0) > > goto out; > > } else > > row = 0;