[PATCH 3/3] omapfb: use of_graph_get_remote_endpoint()

[PATCH 3/3] omapfb: use of_graph_get_remote_endpoint()

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now, we can use of_graph_get_remote_endpoint(). Let's use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
based on 4c9c3d595f1bad021cc126d20879df4016801736
("of_graph: add of_graph_get_remote_endpoint()")

 drivers/video/fbdev/omap2/omapfb/dss/dss-of.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c
index d356a25..f1eb8b0 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss-of.c
@@ -16,6 +16,7 @@
 #include <linux/err.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/of_graph.h>
 #include <linux/seq_file.h>
 
 #include <video/omapfb_dss.h>
@@ -128,7 +129,7 @@ static struct device_node *omapdss_of_get_remote_port(const struct device_node *
 {
 	struct device_node *np;
 
-	np = of_parse_phandle(node, "remote-endpoint", 0);
+	np = of_graph_get_remote_endpoint(node);
 	if (!np)
 		return NULL;
 
-- 
1.9.1

[PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now, we can use of_graph_get_remote_endpoint(). Let's use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
based on 4c9c3d595f1bad021cc126d20879df4016801736
("of_graph: add of_graph_get_remote_endpoint()")

 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 82b978a..66d8cc3 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -309,7 +309,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
 		return -ENODEV;
 	}
 
-	entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);
+	entity_ep_node = of_graph_get_remote_endpoint(ep->local_node);
 
 	for_each_endpoint_of_node(entity, ep_node) {
 		if (ep_node == entity_ep_node)
-- 
1.9.1

Re: [PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

[Laurent Pinchart]

Hi Morimoto-san,

Thank you for the patch.

On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> based on 4c9c3d595f1bad021cc126d20879df4016801736
> ("of_graph: add of_graph_get_remote_endpoint()")

This commit isn't upstream yet. I've taken the patch in my tree and will 
rebase it on top of v4.13-rc1 before submitting it for v4.14.

>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 82b978a..66d8cc3 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -309,7 +309,7 @@ static int rcar_du_encoders_init_one(struct
> rcar_du_device *rcdu, return -ENODEV;
>  	}
> 
> -	entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 
0);
> +	entity_ep_node = of_graph_get_remote_endpoint(ep->local_node);
> 
>  	for_each_endpoint_of_node(entity, ep_node) {
>  		if (ep_node == entity_ep_node)

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote:
>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>
>> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> ---
>> based on 4c9c3d595f1bad021cc126d20879df4016801736
>> ("of_graph: add of_graph_get_remote_endpoint()")
>
> This commit isn't upstream yet. I've taken the patch in my tree and will

FTR, it is in linux-next, but the function has been moved from
drivers/of/base.c to drivers/of/property.c.

> rebase it on top of v4.13-rc1 before submitting it for v4.14.

Note that a simple rebase won't make it disappear, due to the move.
So you'll have to drop it explicitly.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

[Laurent Pinchart]

Hi Geert,

On Thursday 29 Jun 2017 13:22:14 Geert Uytterhoeven wrote:
> On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart wrote:
> > On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote:
> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> 
> >> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
> >> 
> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> >> ---
> >> based on 4c9c3d595f1bad021cc126d20879df4016801736
> >> ("of_graph: add of_graph_get_remote_endpoint()")
> > 
> > This commit isn't upstream yet. I've taken the patch in my tree and will
> 
> FTR, it is in linux-next, but the function has been moved from
> drivers/of/base.c to drivers/of/property.c.

Yes, I've seen the patch in linux-next.

> > rebase it on top of v4.13-rc1 before submitting it for v4.14.
> 
> Note that a simple rebase won't make it disappear, due to the move.
> So you'll have to drop it explicitly.

I'm not sure to follow you. This is a driver patch, depending on a function 
that will make it to v4.13-rc1. At this time it thus doesn't compile against 
mainline. I'll rebase it on top of v4.13-rc1, the dependency will be there, 
and I'll submit it for v4.14.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/3] drm: rcar-du: use of_graph_get_remote_endpoint()

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Jun 29, 2017 at 1:26 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday 29 Jun 2017 13:22:14 Geert Uytterhoeven wrote:
>> On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart wrote:
>> > On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote:
>> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >>
>> >> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
>> >>
>> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >
>> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> >
>> >> ---
>> >> based on 4c9c3d595f1bad021cc126d20879df4016801736
>> >> ("of_graph: add of_graph_get_remote_endpoint()")
>> >
>> > This commit isn't upstream yet. I've taken the patch in my tree and will
>>
>> FTR, it is in linux-next, but the function has been moved from
>> drivers/of/base.c to drivers/of/property.c.
>
> Yes, I've seen the patch in linux-next.
>
>> > rebase it on top of v4.13-rc1 before submitting it for v4.14.
>>
>> Note that a simple rebase won't make it disappear, due to the move.
>> So you'll have to drop it explicitly.
>
> I'm not sure to follow you. This is a driver patch, depending on a function
> that will make it to v4.13-rc1. At this time it thus doesn't compile against
> mainline. I'll rebase it on top of v4.13-rc1, the dependency will be there,
> and I'll submit it for v4.14.

Sorry, I misunderstood you were going to take "of_graph: add
of_graph_get_remote_endpoint()" in your tree as a dependency.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 2/3] media: ti-vpe: cal: use of_graph_get_remote_endpoint()

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Now, we can use of_graph_get_remote_endpoint(). Let's use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
based on 4c9c3d595f1bad021cc126d20879df4016801736
("of_graph: add of_graph_get_remote_endpoint()")

 drivers/media/platform/ti-vpe/cal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index 177faa3..0c7ddf8 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -1702,7 +1702,7 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
 	asd->match_type = V4L2_ASYNC_MATCH_FWNODE;
 	asd->match.fwnode.fwnode = of_fwnode_handle(sensor_node);
 
-	remote_ep = of_parse_phandle(ep_node, "remote-endpoint", 0);
+	remote_ep = of_graph_get_remote_endpoint(ep_node);
 	if (!remote_ep) {
 		ctx_dbg(3, ctx, "can't get remote-endpoint\n");
 		goto cleanup_exit;
-- 
1.9.1

Re: [PATCH 2/3] media: ti-vpe: cal: use of_graph_get_remote_endpoint()

[Sylwester Nawrocki]

On 06/28/2017 02:33 AM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
> 
> Signed-off-by: Kuninori Morimoto<kuninori.morimoto.gx@renesas.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Re: [PATCH 2/3] media: ti-vpe: cal: use of_graph_get_remote_endpoint()

[Benoit Parrot]

Acked-by: Benoit Parrot <bparrot@ti.com>

Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote on Wed [2017-Jun-28 00:33:00 +0000]:
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> based on 4c9c3d595f1bad021cc126d20879df4016801736
> ("of_graph: add of_graph_get_remote_endpoint()")
> 
>  drivers/media/platform/ti-vpe/cal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index 177faa3..0c7ddf8 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -1702,7 +1702,7 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
>  	asd->match_type = V4L2_ASYNC_MATCH_FWNODE;
>  	asd->match.fwnode.fwnode = of_fwnode_handle(sensor_node);
>  
> -	remote_ep = of_parse_phandle(ep_node, "remote-endpoint", 0);
> +	remote_ep = of_graph_get_remote_endpoint(ep_node);
>  	if (!remote_ep) {
>  		ctx_dbg(3, ctx, "can't get remote-endpoint\n");
>  		goto cleanup_exit;
> -- 
> 1.9.1
>