From: Al Viro <viro@ZenIV.linux.org.uk>
To: Gioh Kim <gi-oh.kim@profitbricks.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] guarantee inode of alias's parent
Date: Fri, 7 Jul 2017 15:16:48 +0100 [thread overview]
Message-ID: <20170707141647.GD10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170707132811.18832-1-gi-oh.kim@profitbricks.com>
On Fri, Jul 07, 2017 at 03:28:11PM +0200, Gioh Kim wrote:
> Before __d_unalias(), the dentry and parent of the dentry
> are locked. But I wonder how I can assure of existence of the
> alias and the parent of the alias.
>
> Where is the code to lock alias and alias->d_parent?
Nowhere. Why the hell would you want to lock them?
> What will happend if alias->d_parent be deleted by another process?
Huh? As soon as you've grabbed ->s_vfs_rename_mutex, ->d_parent of everything on
that filesystem is stable - and positive. Moreover, any positive dentry with
references held (in particular, anyone's parent) is going to remain such for
as long as those references are held.
prev parent reply other threads:[~2017-07-07 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 13:28 [RFC] guarantee inode of alias's parent Gioh Kim
2017-07-07 14:16 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707141647.GD10672@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gi-oh.kim@profitbricks.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox