From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752181AbdGGOVs (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Jul 2017 10:21:48 -0400
Received: from mail.kernel.org ([198.145.29.99]:57478 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751013AbdGGOVr (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Fri, 7 Jul 2017 10:21:47 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41EED22B50
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Fri, 7 Jul 2017 11:21:41 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf report: Fix broken arrow at row 0 in annotate view
Message-ID: <20170707142141.GP27350@kernel.org>
References: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1496901704-30275-1-git-send-email-yao.jin@linux.intel.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Jun 08, 2017 at 02:01:44PM +0800, Jin Yao escreveu:
> When the jump instruction is displayed at the row 0 in annotate view,
> the arrow is broken. An example:
> 
>  16.86 │   ┌──je     82
>   0.01 │      movsd  (%rsp),%xmm0
>        │      movsd  0x8(%rsp),%xmm4
>        │      movsd  0x8(%rsp),%xmm1
>        │      movsd  (%rsp),%xmm3
>        │      divsd  %xmm4,%xmm0
>        │      divsd  %xmm3,%xmm1
>        │      movsd  (%rsp),%xmm2
>        │      addsd  %xmm1,%xmm0
>        │      addsd  %xmm2,%xmm0
>        │      movsd  %xmm0,(%rsp)
>        │82:   sub    $0x1,%ebx
>  83.03 │    ↑ jne    38
>        │      add    $0x10,%rsp
>        │      xor    %eax,%eax
>        │      pop    %rbx
>        │    ← retq
> 
> The patch increments the row number before checking with 0.

Thanks, tested and applied!

- Arnaldo