From: Guenter Roeck <linux@roeck-us.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: hwmon: adc128d818: constify attribute_group structures.
Date: Sat, 8 Jul 2017 08:56:37 -0700 [thread overview]
Message-ID: <20170708155637.GA2316@roeck-us.net> (raw)
In-Reply-To: <ea988b4603caf53fa8a1174edf55fcebf604d598.1499232082.git.arvind.yadav.cs@gmail.com>
On Wed, Jul 05, 2017 at 10:52:13AM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2304 2936 0 5240 1478 drivers/hwmon/adc128d818.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2344 2872 0 5216 1460 drivers/hwmon/adc128d818.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/adc128d818.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
> index a557b46..bd2ca31 100644
> --- a/drivers/hwmon/adc128d818.c
> +++ b/drivers/hwmon/adc128d818.c
> @@ -384,7 +384,7 @@ static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO,
> NULL
> };
>
> -static struct attribute_group adc128_group = {
> +static const struct attribute_group adc128_group = {
> .attrs = adc128_attrs,
> .is_visible = adc128_is_visible,
> };
prev parent reply other threads:[~2017-07-08 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 5:22 [PATCH] hwmon: adc128d818: constify attribute_group structures Arvind Yadav
2017-07-08 15:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170708155637.GA2316@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).