* [PATCH] hwmon: adc128d818: constify attribute_group structures.
@ 2017-07-05 5:22 Arvind Yadav
2017-07-08 15:56 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-05 5:22 UTC (permalink / raw)
To: jdelvare, linux; +Cc: linux-hwmon, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2304 2936 0 5240 1478 drivers/hwmon/adc128d818.o
File size After adding 'const':
text data bss dec hex filename
2344 2872 0 5216 1460 drivers/hwmon/adc128d818.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hwmon/adc128d818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
index a557b46..bd2ca31 100644
--- a/drivers/hwmon/adc128d818.c
+++ b/drivers/hwmon/adc128d818.c
@@ -384,7 +384,7 @@ static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO,
NULL
};
-static struct attribute_group adc128_group = {
+static const struct attribute_group adc128_group = {
.attrs = adc128_attrs,
.is_visible = adc128_is_visible,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: hwmon: adc128d818: constify attribute_group structures.
2017-07-05 5:22 [PATCH] hwmon: adc128d818: constify attribute_group structures Arvind Yadav
@ 2017-07-08 15:56 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-07-08 15:56 UTC (permalink / raw)
To: Arvind Yadav; +Cc: jdelvare, linux-hwmon, linux-kernel
On Wed, Jul 05, 2017 at 10:52:13AM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2304 2936 0 5240 1478 drivers/hwmon/adc128d818.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2344 2872 0 5216 1460 drivers/hwmon/adc128d818.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/adc128d818.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
> index a557b46..bd2ca31 100644
> --- a/drivers/hwmon/adc128d818.c
> +++ b/drivers/hwmon/adc128d818.c
> @@ -384,7 +384,7 @@ static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO,
> NULL
> };
>
> -static struct attribute_group adc128_group = {
> +static const struct attribute_group adc128_group = {
> .attrs = adc128_attrs,
> .is_visible = adc128_is_visible,
> };
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-08 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 5:22 [PATCH] hwmon: adc128d818: constify attribute_group structures Arvind Yadav
2017-07-08 15:56 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).