From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbdGISOs (ORCPT ); Sun, 9 Jul 2017 14:14:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:52856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbdGISOq (ORCPT ); Sun, 9 Jul 2017 14:14:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 509E12156A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 9 Jul 2017 19:14:41 +0100 From: Jonathan Cameron To: Colin King Cc: Ludovic Desroches , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio:adc:at91-sama5d2: make array startup_lookup static to reduce code size Message-ID: <20170709191441.54c248f2@kernel.org> In-Reply-To: <20170707160835.19080-1-colin.king@canonical.com> References: <20170707160835.19080-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Jul 2017 17:08:35 +0100 Colin King wrote: > From: Colin Ian King > > Making the const array startup_lookup static rather having it on the > stack saves 69 bytes. Add in missing int specifier to clean up a > checkpatch warning. > > Before: > text data bss dec hex filename > 10297 2800 128 13225 33a9 drivers/iio/adc/at91-sama5d2_adc.o > > After: > text data bss dec hex filename > 10140 2888 128 13156 3364 drivers/iio/adc/at91-sama5d2_adc.o > > Signed-off-by: Colin Ian King Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > drivers/iio/adc/at91-sama5d2_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index e10dca3ed74b..509988a6817a 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -231,7 +231,7 @@ static const struct iio_chan_spec at91_adc_channels[] = { > static unsigned at91_adc_startup_time(unsigned startup_time_min, > unsigned adc_clk_khz) > { > - const unsigned startup_lookup[] = { > + static const unsigned int startup_lookup[] = { > 0, 8, 16, 24, > 64, 80, 96, 112, > 512, 576, 640, 704,