From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752370AbdGIM2q (ORCPT ); Sun, 9 Jul 2017 08:28:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:57150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbdGIM2o (ORCPT ); Sun, 9 Jul 2017 08:28:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07D2D22BDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Sun, 9 Jul 2017 21:28:30 +0900 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Ingo Molnar , Masami Hiramatsu , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] kernel/kprobes: A few trivial updates to jprobes Message-Id: <20170709212830.0ef55f7025055883fac50cc5@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Jul 2017 22:37:23 +0530 "Naveen N. Rao" wrote: > Here is v2 of the patch: > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1434133.html > > As suggested, the first two patches first clean up the existing jprobe > registration functions and rename function_offset_within_entry() to > kprobe_on_func_entry(). The last patch has been updated accordingly. This series looks good to me. Acked-by: Masami Hiramatsu Thanks! > > Thanks, > Naveen > > Naveen N. Rao (3): > kernel/kprobes: Rename [arch_]function_offset_within_entry() to > [arch_]kprobe_on_func_entry() > kernel/kprobes: Simplify register_jprobes() > kernel/kprobes: Ensure that jprobe probepoints are at function entry > > arch/powerpc/kernel/kprobes.c | 2 +- > include/linux/kprobes.h | 4 ++-- > kernel/kprobes.c | 42 ++++++++++++++++++++++++------------------ > kernel/trace/trace_kprobe.c | 2 +- > 4 files changed, 28 insertions(+), 22 deletions(-) > > -- > 2.13.2 > -- Masami Hiramatsu