* [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation
@ 2017-07-04 6:01 Jaya Durga
2017-07-11 17:09 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jaya Durga @ 2017-07-04 6:01 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, rvarsha016, julia.lawall,
binoy.jayan, arnd, louie.lu, devel, linux-kernel, Jaya Durga
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
*/
static int wifi_test;
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wifi_test, int, 0644);
module_param(initmac, charp, 0644);
module_param(video_mode, int, 0644);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation
2017-07-04 6:01 [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga
@ 2017-07-11 17:09 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-07-11 17:09 UTC (permalink / raw)
To: Jaya Durga
Cc: devel, binoy.jayan, arnd, florian.c.schilhabel, rvarsha016,
louie.lu, linux-kernel, julia.lawall, Larry.Finger
On Tue, Jul 04, 2017 at 11:31:15AM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
>
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Did something change from the previous version of this patch? If so,
what?
And again, where are the rest of the patches in this series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation
@ 2017-06-30 5:58 Jaya Durga
2017-07-11 17:08 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jaya Durga @ 2017-06-30 5:58 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, florian.c.schilhabel, rvarsha016, julia.lawall,
binoy.jayan, arnd, louie.lu, devel, linux-kernel, Jaya Durga,
Jaya Durga
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.
Signed-off-by: Jaya Durga <jayad@cdac.in>
---
drivers/staging/rtl8712/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
*/
static int wifi_test;
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
module_param(wifi_test, int, 0644);
module_param(initmac, charp, 0644);
module_param(video_mode, int, 0644);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation
2017-06-30 5:58 Jaya Durga
@ 2017-07-11 17:08 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-07-11 17:08 UTC (permalink / raw)
To: Jaya Durga
Cc: devel, binoy.jayan, Jaya Durga, arnd, florian.c.schilhabel,
rvarsha016, louie.lu, linux-kernel, julia.lawall, Larry.Finger
On Fri, Jun 30, 2017 at 11:28:13AM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
>
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
> drivers/staging/rtl8712/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Where are the other 5 patches in this series?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-11 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-04 6:01 [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga
2017-07-11 17:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-06-30 5:58 Jaya Durga
2017-07-11 17:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox