From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h
Date: Tue, 11 Jul 2017 19:14:49 +0200 [thread overview]
Message-ID: <20170711171449.GC11838@kroah.com> (raw)
In-Reply-To: <dea8ec86c52eb0f89a75774953af127b7e7a7e64.1499388016.git.Craig@craiginches.com>
On Fri, Jul 07, 2017 at 01:47:04AM +0000, Craig Inches wrote:
> This fixes multiple block statements found not to match
> style as per checkpatch
>
> Signed-off-by: Craig Inches <Craig@craiginches.com>
> ---
> drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +++++++++++++--------
> 1 file changed, 81 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/linux/lnet/lnetst.h b/drivers/staging/lustre/include/linux/lnet/lnetst.h
> index ea736f8d5231..a4f9ff01d458 100644
> --- a/drivers/staging/lustre/include/linux/lnet/lnetst.h
> +++ b/drivers/staging/lustre/include/linux/lnet/lnetst.h
> @@ -54,7 +54,8 @@
> #define LSTIO_GROUP_ADD 0xC10 /* add group */
> #define LSTIO_GROUP_LIST 0xC11 /* list all groups in session */
> #define LSTIO_GROUP_INFO 0xC12 /* query default information of
> - * specified group */
> + * specified group
> + */
> #define LSTIO_GROUP_DEL 0xC13 /* delete group */
> #define LSTIO_NODES_ADD 0xC14 /* add nodes to specified group */
> #define LSTIO_GROUP_UPDATE 0xC15 /* update group */
> @@ -102,27 +103,32 @@ struct lstcon_test_ent {
> int tse_type; /* test type */
> int tse_loop; /* loop count */
> int tse_concur; /* concurrency of test */
> -}; /*** test summary entry, for
> - *** list_batch command */
> +}; /* test summary entry, for
> + * list_batch command
> + */
That's odd, what was the *** stuff for?
I'd like to get a lustre maintainer's ack for all of these before I
apply them...
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-11 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 1:46 [PATCH 0/4] Staging: Lustre Style Fixes Craig Inches
2017-07-07 1:46 ` [PATCH 1/4] Staging: Luster: Clean up line over 80Char in lib-lnet.h Craig Inches
2017-07-11 17:13 ` Greg Kroah-Hartman
2017-07-07 1:46 ` [PATCH 2/4] Staging: Lustre Fix up multiple Block Comments in lib-types.h Craig Inches
2017-07-07 1:47 ` [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h Craig Inches
2017-07-11 17:14 ` Greg Kroah-Hartman [this message]
2017-07-12 5:09 ` Dilger, Andreas
2017-07-07 1:47 ` [PATCH 4/4] Staging: Lustre Fix block statement style issue Craig Inches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711171449.GC11838@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox