From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Rogers <mail@mark-rogers.org>
Cc: Frans Klaver <fransklaver@gmail.com>,
devel@driverdev.osuosl.org, karniksayli1995@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs
Date: Tue, 11 Jul 2017 19:27:12 +0200 [thread overview]
Message-ID: <20170711172712.GB5530@kroah.com> (raw)
In-Reply-To: <20170630183927.GA13036@ubuntulaptop>
On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
>
> I agree with all of your comments. Do you think the best course of
> action is to create a new patch with this change alone and forget the
> rest?
>
> - DPRINTK(1, "ks7010_sdio_remove()\n");
> + DPRINTK(1, "%s()\n", __func__);
Lines like this, that are just "here I am!" comments, should all be
deleted anyway, we have ftrace in the kernel, people always seem to
forget about it...
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-11 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 4:52 [PATCH] staging: ks7010: fix styling WARNINGs Mark Rogers
2017-06-30 5:54 ` Frans Klaver
2017-06-30 18:39 ` Mark Rogers
2017-07-11 17:27 ` Greg KH [this message]
2017-07-12 8:08 ` Frans Klaver
-- strict thread matches above, loose matches on Subject: below --
2017-08-01 0:25 [PATCH] Removing Check Errors with checkpatch.pl, Converting from macro to function call Joe Perches
2017-07-31 3:15 ` [PATCH] staging: ks7010: fix styling WARNINGs Ashish Kalra
2017-08-01 1:18 ` Greg KH
2017-08-01 4:29 ` kbuild test robot
2017-08-01 4:31 ` kbuild test robot
2017-08-01 16:11 ` Ashish Kalra
2017-08-01 16:22 ` Joe Perches
2017-08-01 20:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711172712.GB5530@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=fransklaver@gmail.com \
--cc=karniksayli1995@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@mark-rogers.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox