From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933377AbdGKRpU (ORCPT ); Tue, 11 Jul 2017 13:45:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60270 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933210AbdGKRpT (ORCPT ); Tue, 11 Jul 2017 13:45:19 -0400 Date: Tue, 11 Jul 2017 19:45:16 +0200 From: Greg Kroah-Hartman To: Colin Ian King Cc: Hans Verkuil , Mauro Carvalho Chehab , Thomas Petazzoni , Sakari Ailus , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: make const array gamma_par_mask static Message-ID: <20170711174516.GA13259@kroah.com> References: <20170711172002.19757-1-colin.king@canonical.com> <20170711173035.GA12352@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote: > On 11/07/17 18:30, Greg Kroah-Hartman wrote: > > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Don't populate array gamma_par_mask on the stack but instead make it > >> static. Makes the object code smaller by 148 bytes: > >> > >> Before: > >> text data bss dec hex filename > >> 2993 1104 0 4097 1001 drivers/staging/fbtft/fb_st7789v.o > >> > >> After: > >> text data bss dec hex filename > >> 2757 1192 0 3949 f6d drivers/staging/fbtft/fb_st7789v.o > >> > >> Signed-off-by: Colin Ian King > >> --- > >> drivers/media/usb/gspca/xirlink_cit.c | 2 +- > >> drivers/staging/fbtft/fb_st7789v.c | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Your subject doesn't match the patch :( > > Got distracted by the Trump Jnr tweet. Will resend. Dude, the best thing is to just read: https://whatthefuckjusthappenedtoday.com/ once a day, otherwise you will not get any work done ever again...