From: Greg KH <gregkh@linuxfoundation.org>
To: Joseph Wright <rjosephwright@gmail.com>
Cc: arve@android.com, riandrews@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android/ion: fix sparse warnings
Date: Tue, 11 Jul 2017 20:05:23 +0200 [thread overview]
Message-ID: <20170711180523.GA14938@kroah.com> (raw)
In-Reply-To: <20170705001224.13213-1-rjosephwright@gmail.com>
On Wed, Jul 05, 2017 at 12:12:24AM +0000, Joseph Wright wrote:
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
> was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
> was not declared. Should it be static?
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> was not declared. Should it be static?
You are doing two different types of things here, please break this up
into multiple patches.
thanks,
greg k-h
prev parent reply other threads:[~2017-07-11 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 0:12 [PATCH] Staging: android/ion: fix sparse warnings Joseph Wright
2017-07-11 18:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711180523.GA14938@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=rjosephwright@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox