From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756133AbdGKSF3 (ORCPT ); Tue, 11 Jul 2017 14:05:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34892 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110AbdGKSF0 (ORCPT ); Tue, 11 Jul 2017 14:05:26 -0400 Date: Tue, 11 Jul 2017 20:05:23 +0200 From: Greg KH To: Joseph Wright Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: android/ion: fix sparse warnings Message-ID: <20170711180523.GA14938@kroah.com> References: <20170705001224.13213-1-rjosephwright@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170705001224.13213-1-rjosephwright@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 05, 2017 at 12:12:24AM +0000, Joseph Wright wrote: > ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \ > was not declared. Should it be static? > ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \ > was not declared. Should it be static? > ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \ > was not declared. Should it be static? You are doing two different types of things here, please break this up into multiple patches. thanks, greg k-h