Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode

David Carrillo-Cisneros
2017-07-18T04:39:17Z

On Wed, Jul 12, 2017 at 7:31 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Jul 11, 2017 at 04:52:51PM -0700, David Carrillo-Cisneros wrote:
>> v5: - Fix buffer leaking and size changes in
>> perf_event__synthesize_features.
>> - Remove unnecessary renaming.
>> - Remove extra tabs in do_write_string.
>
> SNIP
>
>>
>> Only patches 14 to 16 have a significant effect in user observed behavior.
>> All other are transparent preparatory changes or bug fixes.
>>
>> David Carrillo-Cisneros (16):
>> perf header: encapsulate read and swap
>> perf header: add PROCESS_STR_FUN macro
>> perf header: fail on write_padded error
>> perf util: add const modifier to buf in "writen" function
>> perf header: revamp do_write
>> perf header: add struct feat_fd for write
>> perf header: use struct feat_fd for print
>> perf header: use struct feat_fd to process header records
>> perf header: don't pass struct perf_file_section to process_##_feat
>> perf header: use struct feat_fd in read header records
>> perf header: make write_pmu_mappings pipe-mode friendly
>
> hum, not sure if that's an issue on my side, but I can see
> only patches 0-11 (above portion), missing patches 12-16:

Mmm, no idea. I reposted a new version and also uploaded it to
https://github.com/ccdavid/linux/tree/toup_july16_pipeheaders_02

>
>> perf header: add a buffer to struct feat_fd
>> perf header: change FEAT_OP* macros
>> perf tool: add show_feature_header to perf_tool
>> perf tools: add feature header record to pipe-mode
>> perf header: add event desc to pipe-mode header
>
>
> jirka