From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbdGLPnv (ORCPT ); Wed, 12 Jul 2017 11:43:51 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52135 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbdGLPnu (ORCPT ); Wed, 12 Jul 2017 11:43:50 -0400 Date: Wed, 12 Jul 2017 17:43:47 +0200 From: Andrew Lunn To: Aviad Krawczyk Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH net 20/20] net/hinic: Add ethtool and stats Message-ID: <20170712154347.GH2557@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2017 at 10:17:26PM +0800, Aviad Krawczyk wrote: Hi Avaid > + > +static void hinic_tx_timeout(struct net_device *netdev) > +{ > + struct hinic_dev *nic_dev = netdev_priv(netdev); > + > + netif_err(nic_dev, drv, netdev, "Tx timeout\n"); > +} > + > +#ifdef CONFIG_NET_POLL_CONTROLLER > +static void hinic_netpoll(struct net_device *netdev) > +{ > + struct hinic_dev *nic_dev = netdev_priv(netdev); > + struct hinic_hwdev *hwdev = nic_dev->hwdev; > + int i, num_qps = hinic_hwdev_num_qps(hwdev); > + > + for (i = 0; i < num_qps; i++) { > + struct hinic_txq *txq = &nic_dev->txqs[i]; > + struct hinic_rxq *rxq = &nic_dev->rxqs[i]; > + > + napi_schedule(&txq->napi); > + napi_schedule(&rxq->napi); > + } > +} > +#endif This has nothing to do with ethtool support. Separate patch please. Andrew