From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH]: documentation,atomic: Add a new atomic_t document
Date: Wed, 12 Jul 2017 12:13:24 -0700 [thread overview]
Message-ID: <20170712191324.GF2393@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170712130826.6qs4fcrwkowe4uoh@hirez.programming.kicks-ass.net>
On Wed, Jul 12, 2017 at 03:08:26PM +0200, Peter Zijlstra wrote:
> On Wed, Jul 12, 2017 at 08:53:47PM +0800, Boqun Feng wrote:
> > On Mon, Jun 12, 2017 at 04:49:29PM +0200, Peter Zijlstra wrote:
> > [...]
> > > -Any atomic operation that modifies some state in memory and returns information
> > > -about the state (old or new) implies an SMP-conditional general memory barrier
> > > -(smp_mb()) on each side of the actual operation (with the exception of
> > > -explicit lock operations, described later). These include:
> > > -
> > > - xchg();
> > > - atomic_xchg(); atomic_long_xchg();
> > > - atomic_inc_return(); atomic_long_inc_return();
> > > - atomic_dec_return(); atomic_long_dec_return();
> > > - atomic_add_return(); atomic_long_add_return();
> > > - atomic_sub_return(); atomic_long_sub_return();
> > > - atomic_inc_and_test(); atomic_long_inc_and_test();
> > > - atomic_dec_and_test(); atomic_long_dec_and_test();
> > > - atomic_sub_and_test(); atomic_long_sub_and_test();
> > > - atomic_add_negative(); atomic_long_add_negative();
> > > - test_and_set_bit();
> > > - test_and_clear_bit();
> > > - test_and_change_bit();
> > > -
> >
> > The bit related operations are removed from memory-barriers.txt, I think
> > we'd better add them in atomic_t.txt? By "them", I mean:
> >
> > test_and_{set,clear,change}_bit() as RMW atomic
> >
> > {set,clear,change}_bit() as non-RMW atomic
> >
> > test_and_set_bit_lock()
> > clear_bit_unlock() as non-RMW(but barrier-like) atomic
>
> I was thinking maybe a separate file, as I was hoping to eventually
> write a separate file on spinlocks too.
>
> I'd like to keep the the new thing purely about the atomic* family of
> stuff, that's large enough as is.
As long as wherever the information is kept actually gets updated when
new functions are added or old ones change, I am good.
Thanx, Paul
next prev parent reply other threads:[~2017-07-12 19:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 9:24 [RFC][PATCH]: documentation,atomic: Add a new atomic_t document Peter Zijlstra
2017-06-09 11:05 ` [RFC][PATCH] atomic: Fix atomic_set_release() for 'funny' architectures Peter Zijlstra
2017-06-09 11:13 ` Peter Zijlstra
2017-06-09 17:28 ` Vineet Gupta
2017-06-09 18:49 ` Peter Zijlstra
2017-06-09 18:58 ` James Bottomley
2017-06-09 14:03 ` Chris Metcalf
2017-08-10 12:10 ` [tip:locking/core] locking/atomic: " tip-bot for Peter Zijlstra
2017-06-09 15:44 ` [RFC][PATCH]: documentation,atomic: Add a new atomic_t document Will Deacon
2017-06-09 19:36 ` Peter Zijlstra
2017-06-11 13:56 ` Boqun Feng
2017-06-12 14:49 ` Peter Zijlstra
2017-06-13 6:39 ` Boqun Feng
2017-06-14 12:33 ` Will Deacon
2017-07-12 12:53 ` Boqun Feng
2017-07-12 13:08 ` Peter Zijlstra
2017-07-12 19:13 ` Paul E. McKenney [this message]
2017-07-26 11:53 ` [RFC][PATCH v3]: documentation,atomic: Add new documents Peter Zijlstra
2017-07-26 12:47 ` Boqun Feng
2017-07-31 9:05 ` Peter Zijlstra
2017-07-31 11:04 ` Boqun Feng
2017-07-31 17:43 ` Paul E. McKenney
2017-08-01 2:14 ` Boqun Feng
2017-08-01 9:01 ` Peter Zijlstra
2017-08-01 10:19 ` Will Deacon
2017-08-01 11:47 ` Peter Zijlstra
2017-08-01 12:17 ` Will Deacon
2017-08-01 12:52 ` Peter Zijlstra
2017-08-01 16:14 ` Paul E. McKenney
2017-08-01 16:42 ` Peter Zijlstra
2017-08-01 16:53 ` Will Deacon
2017-08-01 22:18 ` Paul E. McKenney
2017-08-02 8:46 ` Will Deacon
2017-08-01 18:37 ` Paul E. McKenney
2017-08-02 9:45 ` Will Deacon
2017-08-02 16:17 ` Paul E. McKenney
2017-08-03 14:05 ` Boqun Feng
2017-08-03 14:55 ` Paul E. McKenney
2017-08-03 16:12 ` Will Deacon
2017-08-03 16:58 ` Paul E. McKenney
2017-08-01 13:35 ` Paul E. McKenney
2017-07-26 16:28 ` Randy Dunlap
2017-06-09 18:15 ` [RFC][PATCH]: documentation,atomic: Add a new atomic_t document Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712191324.GF2393@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox