* [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure
@ 2017-07-13 5:47 Gustavo A. R. Silva
2017-07-13 14:19 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-13 5:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Thierry Reding, Jonathan Hunter
Cc: alsa-devel, linux-tegra, linux-kernel, Gustavo A. R. Silva
This structure is only stored in the ops field of a snd_soc_dai_driver
structure. That field is declared const, so snd_soc_dai_ops structures
that have this property can be declared as const also.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/soc/tegra/tegra30_i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
index b2b279c..0b176ea 100644
--- a/sound/soc/tegra/tegra30_i2s.c
+++ b/sound/soc/tegra/tegra30_i2s.c
@@ -275,7 +275,7 @@ static int tegra30_i2s_probe(struct snd_soc_dai *dai)
return 0;
}
-static struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
+static const struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
.set_fmt = tegra30_i2s_set_fmt,
.hw_params = tegra30_i2s_hw_params,
.trigger = tegra30_i2s_trigger,
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure
2017-07-13 5:47 [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure Gustavo A. R. Silva
@ 2017-07-13 14:19 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2017-07-13 14:19 UTC (permalink / raw)
To: Gustavo A. R. Silva, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Thierry Reding
Cc: alsa-devel, linux-tegra, linux-kernel
On 13/07/17 06:47, Gustavo A. R. Silva wrote:
> This structure is only stored in the ops field of a snd_soc_dai_driver
> structure. That field is declared const, so snd_soc_dai_ops structures
> that have this property can be declared as const also.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> sound/soc/tegra/tegra30_i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
> index b2b279c..0b176ea 100644
> --- a/sound/soc/tegra/tegra30_i2s.c
> +++ b/sound/soc/tegra/tegra30_i2s.c
> @@ -275,7 +275,7 @@ static int tegra30_i2s_probe(struct snd_soc_dai *dai)
> return 0;
> }
>
> -static struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
> +static const struct snd_soc_dai_ops tegra30_i2s_dai_ops = {
> .set_fmt = tegra30_i2s_set_fmt,
> .hw_params = tegra30_i2s_hw_params,
> .trigger = tegra30_i2s_trigger,
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-13 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-13 5:47 [PATCH] ASoC: tegra: constify snd_soc_dai_ops structure Gustavo A. R. Silva
2017-07-13 14:19 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox