From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniel Wagner <wagi@monom.org>,
David Woodhouse <dwmw2@infradead.org>,
rafal@milecki.pl, Arend van Spriel <arend.vanspriel@broadcom.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
yi1.li@linux.intel.com, atull@kernel.org,
Moritz Fischer <moritz.fischer@ettus.com>,
pmladek@suse.com, Johannes Berg <johannes.berg@intel.com>,
emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
Kalle Valo <kvalo@codeaurora.org>,
luto@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
David Howells <dhowells@redhat.com>,
pjones@redhat.com, Hans de Goede <hdegoede@redhat.com>,
alan@linux.intel.com, tytso@mit.edu,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: remove request_firmware_into_buf()
Date: Thu, 13 Jul 2017 09:46:28 +0200 [thread overview]
Message-ID: <20170713074628.GA3877@kroah.com> (raw)
In-Reply-To: <20170712234434.GA21846@wotan.suse.de>
On Thu, Jul 13, 2017 at 01:44:34AM +0200, Luis R. Rodriguez wrote:
> On Tue, Jun 27, 2017 at 10:37:11AM -0700, Bjorn Andersson wrote:
> > On Mon 26 Jun 23:52 PDT 2017, Greg Kroah-Hartman wrote:
> > > Why would we keep it if there is no in-tree user for it? If you want it
> > > sometime in the future, great, we can revert the deletion then, but
> > > keeping it around for nothing isn't ok, you know that :)
> > >
> >
> > Of course I know that :)
> >
> > I did put a patch in the tubes for this yesterday [1], it's late for
> > v4.13, but I would be happy to see the API stay and we would have a user
> > in v4.14 (and tick this off Qualcomm's "required" list).
> >
> > [1] https://lkml.org/lkml/2017/6/26/693
>
> Greg,
>
> What have you decided to do?
Given that this didn't go in for 4.13-rc1, I figured it was kind of
obvious, I'm waiting to see if a user shows up for this release :)
And it's always trivial to revert a patch to add an api back if someone
does need/want it, so this shouldn't be a big deal to anyone.
> Also what is the threshold for number of drivers to use a new feature for us to
> add it? Note that there is a bundle of features queued up now and as per your
> own preference it would seem you want a new API call for each new feature...
Usually it's a good engineering practice to have 3 users of any
interface to prove that you got the interface correct, right? But I'm
not making any hard and fast rule here, let's see the patches and judge
it from there...
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-13 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 16:03 [PATCH] firmware: remove request_firmware_into_buf() Greg Kroah-Hartman
2017-06-26 20:22 ` Bjorn Andersson
2017-06-27 6:52 ` Greg Kroah-Hartman
2017-06-27 17:37 ` Bjorn Andersson
2017-07-12 23:44 ` Luis R. Rodriguez
2017-07-13 7:46 ` Greg Kroah-Hartman [this message]
2017-06-27 12:54 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713074628.GA3877@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox