From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 1/2] nvmet: Move serial number from controller to subsystem
Date: Fri, 14 Jul 2017 13:03:02 +0200 [thread overview]
Message-ID: <20170714110302.GA22871@lst.de> (raw)
In-Reply-To: <20170714110004.11886-2-jthumshirn@suse.de>
> + if (!subsys->serial)
> + get_random_bytes(&subsys->serial, sizeof(subsys->serial));
This should move to nvmet_subsys_alloc instead.
next prev parent reply other threads:[~2017-07-14 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 11:00 [PATCH 0/2] Provide a stable serial number Johannes Thumshirn
2017-07-14 11:00 ` [PATCH 1/2] nvmet: Move serial number from controller to subsystem Johannes Thumshirn
2017-07-14 11:03 ` Christoph Hellwig [this message]
2017-07-14 11:00 ` [PATCH 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714110302.GA22871@lst.de \
--to=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox