From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots
Date: Fri, 14 Jul 2017 14:46:32 +0200 [thread overview]
Message-ID: <20170714124632.GA13633@linux-x5ow.site> (raw)
In-Reply-To: <20170714123208.GE26187@lst.de>
On Fri, Jul 14, 2017 at 02:32:08PM +0200, Christoph Hellwig wrote:
> This patch itself looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > static struct configfs_attribute *nvmet_subsys_attrs[] = {
> > &nvmet_subsys_attr_attr_allow_any_host,
> > &nvmet_subsys_attr_version,
> > + &nvmet_subsys_attr_attr_serial,
>
> but the new version attribute really needs the attr prefix so that
> nvmetcli can pick it up. And we should also add nvmetcli support
> for it. Can you do the rename before your series to ease backporting
> as that should go into 3.12 (just like your serial number fix).
>
Is it OK if I send the patches in the same series?
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-07-14 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 12:05 [PATCH v2 0/2] Provide a stable serial number Johannes Thumshirn
2017-07-14 12:05 ` [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem Johannes Thumshirn
2017-07-14 12:31 ` Christoph Hellwig
2017-07-14 12:05 ` [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn
2017-07-14 12:32 ` Christoph Hellwig
2017-07-14 12:46 ` Johannes Thumshirn [this message]
2017-07-14 12:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714124632.GA13633@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox