From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbdGOShw (ORCPT ); Sat, 15 Jul 2017 14:37:52 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:55554 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbdGOShu (ORCPT ); Sat, 15 Jul 2017 14:37:50 -0400 Date: Sat, 15 Jul 2017 20:37:45 +0200 From: Andrew Lunn To: Moritz Fischer Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, mark.rutland@arm.com, robh+dt@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Message-ID: <20170715183745.GA28217@lunn.ch> References: <1500065326-26182-1-git-send-email-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500065326-26182-1-git-send-email-mdf@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > This adds bindings for the NI XGE 1G/10G network device. > > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/net/nixge.txt | 32 +++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nixge.txt > > diff --git a/Documentation/devicetree/bindings/net/nixge.txt b/Documentation/devicetree/bindings/net/nixge.txt > new file mode 100644 > index 0000000..9fff5a7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nixge.txt > @@ -0,0 +1,32 @@ > +* NI XGE Ethernet controller > + > +Required properties: > +- compatible: Should be "ni,xge-enet-2.00" > +- reg: Address and length of the register set for the device > +- interrupts: Should contain tx and rx interrupt > +- interrupt-names: Should be "rx-irq" and "tx-irq" > +- phy-mode: See ethernet.txt file in the same directory. Hi Moritz phy-handle is now required. > +Examples (10G generic PHY): > + nixge0: ethernet@40000000 { > + compatible = "ni,xge-enet-2.00"; > + reg = <0x40000000 0x6000>; > + > + nvmem-cells = <ð1_addr>; > + nvmem-cell-names = "address"; > + > + interrupts = <0 29 4>, <0 30 4>; IRQ_TYPE_LEVEL_HIGH > + interrupt-names = "rx-irq", "tx-irq"; > + interrupt-parent = <&intc>; > + > + phy-mode = "xgmii"; > + phy-handle = <ðernet_phy1>; > + > + ethernet_phy1: ethernet-phy@4 { > + compatible = "ethernet-phy-ieee802.3-c45"; > + reg = <4>; > + devices = <0xa>; > + }; Since you don't fully implement c45, does this example actually work? And devices is not a standard phy property. Andrew