Re: [PATCH 5/6] cgroup: implement cgroup v2 thread support

Tejun Heo
2017-07-18T17:55:02Z

Hello, Peter.

On Tue, Jul 18, 2017 at 07:28:01PM +0200, Peter Zijlstra wrote:
> > And now try to create another child C, should that be a domain or
> > threaded?
>
> Domain of course, as R must be a domain, and hence all its children
> start out as such.

I don't think it's a matter of course as R also is the root of a
threaded subtree, but this is more or less bikeshedding.

> > If we only inherit from the second level on, which is in itself
> > already confusing, that still leads to invalid configs for non-root
> > thread roots.
>
> I don't see how. I don't get the example Waiman gave, what is wrong
> with:
>
> R (D)
> |
> A (D)
> / \
> C(D) B(T)
>
> ? Afaict that's a perfectly valid configuration.

Okay, we're kinda off the rails now. Just to verify that we're on the
same page, are you also saying that the following should be a valid
configuration?

R (D)
|
A (D and has processes in it and controllers enabled)
|
C (D and has processes in it)

Thanks.

--
tejun