From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbdGQLiC (ORCPT ); Mon, 17 Jul 2017 07:38:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdGQLiB (ORCPT ); Mon, 17 Jul 2017 07:38:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B1B6E80F9D Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B1B6E80F9D Date: Mon, 17 Jul 2017 13:37:58 +0200 From: Jiri Olsa To: Andi Kleen Cc: Jiri Olsa , Peter Zijlstra , lkml , Ingo Molnar , Alexander Shishkin , Kan Liang Subject: Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events Message-ID: <20170717113758.GC1007@krava> References: <20170714163551.19459-1-jolsa@kernel.org> <87d193lyqe.fsf@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d193lyqe.fsf@firstfloor.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 17 Jul 2017 11:38:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > Jiri Olsa writes: > > > > Setting the reset field to 0 for freq events. > > Looks good to me. > > Reviewed-by: Andi Kleen > > BTW I suspect there's a related bug that > > perf record -e '{cycles:pp,branches}:S' .. > > would enable multi record PEBS, even though it shouldn't because > we need the PMI to read the other events. there's PERF_SAMPLE_READ om cycles's sample_type for this example so it won't pass the x86_pmu::free_running_flags filter also PERF_SAMPLE_TIME and PERF_SAMPLE_PERIOD will be set in your example which will prevent that, but those could be unset via record's '-c xxxx' and '--no-timestamp' jirka