From: Greg Kroah-Hartman <greg@kroah.com>
To: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: [PATCH v2 1/4] w1: ds1wm: fix and simplify register access
Date: Mon, 17 Jul 2017 16:55:50 +0200 [thread overview]
Message-ID: <20170717145550.GC7084@kroah.com> (raw)
In-Reply-To: <1498214835-11186-2-git-send-email-johannes.poehlmann@izt-labs.de>
On Fri, Jun 23, 2017 at 12:47:12PM +0200, Johannes Poehlmann wrote:
> o Replace incorrect register offsett calculation by
> direct configuration of bus_shift in mfd-cell.
> Indirect definition of address-shift by resource size
> was unobvious and should have used a binary log.
> o Make endian clean, make HW-endianness configurable.
> o Use ioread*, iowrite* instead of __raw_readb,__raw_writeb
> to also use memory-barriers when accessing HW-registers.
> We do not want reordering to happen here.
>
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@izt-labs.de>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>
> 78 6 drivers/w1/masters/ds1wm.c
> 9 0 include/linux/mfd/ds1wm.h
And again, something went wrong here :(
next prev parent reply other threads:[~2017-07-17 14:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 11:38 [PATCH V1] one wire ds1wm patch Johannes Pöhlmann
2017-06-19 14:55 ` Evgeniy Polyalkov
2017-06-19 15:24 ` Greg Kroah-Hartman
2017-06-19 17:38 ` kbuild test robot
[not found] ` <1498214835-11186-1-git-send-email-johannes.poehlmann@izt-labs.de>
2017-06-29 13:32 ` [PATCH v2 0/4] w1: ds1wm: register access patch Evgeniy Polyakov
[not found] ` <1498214835-11186-4-git-send-email-johannes.poehlmann@izt-labs.de>
2017-07-17 14:55 ` [PATCH v2 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt Greg Kroah-Hartman
[not found] ` <1498214835-11186-5-git-send-email-johannes.poehlmann@izt-labs.de>
2017-07-17 14:55 ` [PATCH v2 4/4] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Greg Kroah-Hartman
[not found] ` <1498214835-11186-2-git-send-email-johannes.poehlmann@izt-labs.de>
2017-07-17 14:55 ` Greg Kroah-Hartman [this message]
2017-07-18 11:26 ` [PATCH v3 0/4] w1: ds1wm: register access patch Johannes Poehlmann
2017-07-18 11:26 ` [PATCH v3 1/4] w1: ds1wm: fix and simplify register access Johannes Poehlmann
2017-07-18 14:15 ` Greg Kroah-Hartman
2017-07-25 11:27 ` [PATCH v4 0/5] w1: ds1wm: register access patch Johannes Poehlmann
2017-08-27 7:19 ` Evgeniy Polyakov
2017-07-25 11:27 ` [PATCH v4 1/5] w1: ds1wm: fix register offset (bus shift) calculation Johannes Poehlmann
2017-07-25 11:27 ` [PATCH v4 2/5] w1: ds1wm: make endian clean and use standard io memory accessors Johannes Poehlmann
2017-07-25 11:27 ` [PATCH v4 3/5] w1: ds1wm: add level interrupt modes Johannes Poehlmann
2017-07-25 11:27 ` [PATCH v4 4/5] w1: ds1wm: silence interrupts on HW before claiming the interrupt Johannes Poehlmann
2017-07-25 11:27 ` [PATCH v4 5/5] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Johannes Poehlmann
2017-07-18 11:26 ` [PATCH v3 2/4] w1: ds1wm: add level interrupt modes Johannes Poehlmann
2017-07-18 14:15 ` Greg Kroah-Hartman
2017-07-18 11:26 ` [PATCH v3 3/4] w1: ds1wm: silence interrupts on HW before claiming the interrupt Johannes Poehlmann
2017-07-18 14:15 ` Greg Kroah-Hartman
2017-07-18 11:26 ` [PATCH v3 4/4] w1: ds1wm: add messages to make incorporation in mfd-drivers easier Johannes Poehlmann
2017-07-18 14:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717145550.GC7084@kroah.com \
--to=greg@kroah.com \
--cc=johannes.poehlmann@izt-labs.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox