From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbdGQSHK (ORCPT ); Mon, 17 Jul 2017 14:07:10 -0400 Received: from one.firstfloor.org ([193.170.194.197]:46702 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdGQSHJ (ORCPT ); Mon, 17 Jul 2017 14:07:09 -0400 Date: Mon, 17 Jul 2017 11:07:07 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , Jiri Olsa , Peter Zijlstra , lkml , Ingo Molnar , Alexander Shishkin , Kan Liang Subject: Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events Message-ID: <20170717180706.GK3044@two.firstfloor.org> References: <20170714163551.19459-1-jolsa@kernel.org> <87d193lyqe.fsf@firstfloor.org> <20170717113758.GC1007@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717113758.GC1007@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 01:37:58PM +0200, Jiri Olsa wrote: > On Fri, Jul 14, 2017 at 10:22:49AM -0700, Andi Kleen wrote: > > Jiri Olsa writes: > > > > > > Setting the reset field to 0 for freq events. > > > > Looks good to me. > > > > Reviewed-by: Andi Kleen > > > > BTW I suspect there's a related bug that > > > > perf record -e '{cycles:pp,branches}:S' .. > > > > would enable multi record PEBS, even though it shouldn't because > > we need the PMI to read the other events. > > there's PERF_SAMPLE_READ om cycles's sample_type for this example > so it won't pass the x86_pmu::free_running_flags filter Good thanks for checking. > > also PERF_SAMPLE_TIME and PERF_SAMPLE_PERIOD will be set > in your example which will prevent that, but those > could be unset via record's '-c xxxx' and '--no-timestamp' PERF_SAMPLE_TIME works with Skylake/goldmont, but yes forgot the -c. -Andi