From: Greg KH <gregkh@linuxfoundation.org>
To: Gaurav Pathak <gauravpathak129@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__
Date: Tue, 18 Jul 2017 08:57:41 +0200 [thread overview]
Message-ID: <20170718065741.GA15523@kroah.com> (raw)
In-Reply-To: <1500302985-1775-1-git-send-email-gauravpathak129@gmail.com>
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char
No, only do one-type-of-thing per patch. It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.
Please break this up into individual patches.
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-18 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:00 [PATCH] staging: rts5208: Replace embedded function names with "%s: ", __func__ Gaurav Pathak
2017-07-06 19:00 ` kbuild test robot
2017-07-06 20:14 ` kbuild test robot
2017-07-07 15:59 ` Gaurav Pathak
2017-07-11 17:25 ` Greg KH
2017-07-13 14:32 ` [PATCH v1] staging: rts5208: Change fixed " Gaurav Pathak
2017-07-13 14:38 ` Greg KH
[not found] ` <08096761-5c72-f1a4-d04f-cd87b451b46f@gmail.com>
[not found] ` <20170713153859.GA5047@kroah.com>
2017-07-13 16:00 ` Gaurav Pathak
2017-07-13 16:24 ` Greg KH
2017-07-14 14:08 ` Gaurav Pathak
2017-07-17 12:28 ` Greg KH
2017-07-17 14:49 ` Gaurav Pathak
2017-07-18 6:57 ` Greg KH [this message]
2017-07-20 16:12 ` Gaurav Pathak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718065741.GA15523@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gauravpathak129@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox