From: Greg KH <gregkh@linuxfoundation.org>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org, riehecky@fnal.gov, federico.vaga@cern.ch
Subject: Re: [PATCH V3 1/5] drivers/fmc: remove unused variable
Date: Tue, 18 Jul 2017 09:23:49 +0200 [thread overview]
Message-ID: <20170718072349.GA15087@kroah.com> (raw)
In-Reply-To: <20170718070029.GA24230@mail.gnudd.com>
On Tue, Jul 18, 2017 at 09:00:29AM +0200, Alessandro Rubini wrote:
> > Again, I do not like to take patches without any changelog text at all
> > :(
>
> Sorry, I added this after the "---" line. I thought it was this one the
> missing item:
>
> V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
>
> V2 (Pat): added Tested-by and incorrect From line
>
> V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.
Ah, sorry, wrong "changelog". I meant the area that shows up in git
about what this patch does. There's no description of it other than the
Subject line. While this is a simple patch, it is always good to say
something like "variable foo was set but never actually used, so it's
safe to remove it as the function it called did not change the hardware
state" or something like that.
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-18 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 6:32 [PATCH V3 1/5] drivers/fmc: remove unused variable Alessandro Rubini
2017-07-18 6:53 ` Greg KH
2017-07-18 7:00 ` Alessandro Rubini
2017-07-18 7:23 ` Greg KH [this message]
2017-07-18 7:30 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718072349.GA15087@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=federico.vaga@cern.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=riehecky@fnal.gov \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox