From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdGRIVN (ORCPT ); Tue, 18 Jul 2017 04:21:13 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34665 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdGRIVL (ORCPT ); Tue, 18 Jul 2017 04:21:11 -0400 Date: Tue, 18 Jul 2017 10:21:18 +0200 From: Johan Hovold To: Mark Brown Cc: Johan Hovold , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linus Walleij , alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Message-ID: <20170718082118.GG29638@localhost> References: <20170712155530.17765-1-johan@kernel.org> <20170712155530.17765-2-johan@kernel.org> <20170717145127.ke5o65as35itamaf@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717145127.ke5o65as35itamaf@sirena.org.uk> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 03:51:27PM +0100, Mark Brown wrote: > On Wed, Jul 12, 2017 at 05:55:30PM +0200, Johan Hovold wrote: > > This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI > > assignments"), which seems to have been based on a misunderstanding and > > prevents the platform driver callbacks from being made (e.g. to > > preallocate DMA memory). > > Please submit patches using subject lines reflecting the style for the > subsystem. This makes it easier for people to identify relevant > patches. Look at what existing commits in the area you're changing are > doing and make sure your subject lines visually resemble what they're > doing. I try to, but reverts are special as the default commit summary tend to already contain the subsystem prefix and some maintainers find that sufficient (or even preferred as this also makes reverts stand out more clearly). But now I know your preference, and thanks for fixing it up this time before applying. Johan