From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
kjlx@templeofstupid.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map()
Date: Tue, 18 Jul 2017 12:45:38 -0300 [thread overview]
Message-ID: <20170718154538.GF10517@kernel.org> (raw)
In-Reply-To: <874luaje4u.fsf@concordia.ellerman.id.au>
Em Tue, Jul 18, 2017 at 07:19:45PM +1000, Michael Ellerman escreveu:
> Arnaldo Carvalho de Melo <acme@kernel.org> writes:
>
> > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu:
> >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in
> >> alternate namespaces.") is causing a build failure on powerpc:
> >>
> >> error: incompatible type for argument 2 of 'get_target_map'
> >> map = get_target_map(pev->target, pev->uprobes);
> >> ^~~
> >>
> >> Fix it by changing parameters of get_target_map().
> >
> > Thanks, since this hasn't made it to Ingo I'll fold this into the patch
> > where the problem was introduced, adding credits to you, leaving a Link
> > to this message, so that we don't lose bisection in this area on
> > powerpc.
>
> Thanks.
>
> I just bisected to this commit too - should have checked the list first! :)
:-)
I just re-ammended this cset to cover the !HAVE_DWARF_SUPPORT build as
well, just re-force-pushed acme/perf/core with this fix.
- Arnaldo
next prev parent reply other threads:[~2017-07-18 15:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 2:18 [PATCH tip/perf/core 0/7] namespace tracing improvements Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 1/7] perf symbols: find symbols in different mount namespace Krister Johansen
2017-07-03 18:38 ` Arnaldo Carvalho de Melo
2017-07-05 20:44 ` Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 2/7] perf maps: lookup maps in both intitial mountns and inner mountns Krister Johansen
2017-07-03 18:44 ` Arnaldo Carvalho de Melo
2017-07-01 2:18 ` [PATCH tip/perf/core 3/7] perf probe: allow placing uprobes in alternate namespaces Krister Johansen
2017-07-03 18:46 ` Arnaldo Carvalho de Melo
2017-07-05 20:45 ` Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 4/7] perf buildid-cache: support binary objects from other namespaces Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 5/7] perf top: support lookup of symbols in other mount namespaces Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 6/7] perf documentation: updates for target-ns Krister Johansen
2017-07-03 18:48 ` Arnaldo Carvalho de Melo
2017-07-05 20:45 ` Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 0/6] namespace tracing improvements Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 1/6] perf symbols: find symbols in different mount namespace Krister Johansen
2017-07-06 19:41 ` Arnaldo Carvalho de Melo
2017-07-07 19:36 ` Krister Johansen
2017-07-10 6:17 ` Thomas-Mich Richter
2017-07-10 22:39 ` Krister Johansen
2017-07-10 22:52 ` Arnaldo Carvalho de Melo
2017-07-10 23:29 ` Krister Johansen
2017-07-11 12:51 ` Arnaldo Carvalho de Melo
2017-07-11 17:15 ` Krister Johansen
2017-07-20 8:48 ` [tip:perf/core] perf symbols: Find " tip-bot for Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 2/6] perf maps: lookup maps in both intitial mountns and inner mountns Krister Johansen
2017-07-20 8:48 ` [tip:perf/core] perf maps: Lookup " tip-bot for Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 3/6] perf probe: allow placing uprobes in alternate namespaces Krister Johansen
2017-07-17 10:32 ` [PATCH] perf probe: Fix build failure for get_target_map() Ravi Bangoria
2017-07-17 13:11 ` Arnaldo Carvalho de Melo
2017-07-18 9:19 ` Michael Ellerman
2017-07-18 15:45 ` Arnaldo Carvalho de Melo [this message]
2017-07-19 5:58 ` Michael Ellerman
2017-07-20 8:48 ` [tip:perf/core] perf probe: Allow placing uprobes in alternate namespaces tip-bot for Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 4/6] perf buildid-cache: support binary objects from other namespaces Krister Johansen
2017-07-20 8:49 ` [tip:perf/core] perf buildid-cache: Support " tip-bot for Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 5/6] perf top: support lookup of symbols in other mount namespaces Krister Johansen
2017-07-21 17:10 ` Arnaldo Carvalho de Melo
2017-07-26 17:23 ` [tip:perf/core] perf top: Support " tip-bot for Krister Johansen
2017-07-06 1:48 ` [PATCH v2 tip/perf/core 6/6] perf buildid-cache: cache debuginfo Krister Johansen
2017-07-20 8:49 ` [tip:perf/core] perf buildid-cache: Cache debuginfo tip-bot for Krister Johansen
2017-07-01 2:18 ` [PATCH tip/perf/core 7/7] perf buildid-cache: cache debuginfo Krister Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718154538.GF10517@kernel.org \
--to=acme@kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox