From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbdGRQ5h (ORCPT ); Tue, 18 Jul 2017 12:57:37 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:35833 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbdGRQ4t (ORCPT ); Tue, 18 Jul 2017 12:56:49 -0400 Date: Tue, 18 Jul 2017 09:56:44 -0700 From: Bjorn Andersson To: Varadarajan Narayanan Cc: bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com, svarbanov@mm-sol.com, kishon@ti.com, sboyd@codeaurora.org, vivek.gautam@codeaurora.org, fengguang.wu@intel.com, weiyongjun1@huawei.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name Message-ID: <20170718165644.GF20973@minitux> References: <1500293043-1887-1-git-send-email-varada@codeaurora.org> <1500293043-1887-4-git-send-email-varada@codeaurora.org> <20170717223047.GA20973@minitux> <20170718085440.GD32439@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718085440.GD32439@codeaurora.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 18 Jul 01:54 PDT 2017, Varadarajan Narayanan wrote: > On Mon, Jul 17, 2017 at 03:30:47PM -0700, Bjorn Andersson wrote: [..] > > > > This would be the case for any existing dts files, so you're not allowed > > to treat this as an error. > > Since, there are no dts files that presently enable this driver, > wouldn't it be better to flag this as an error now itself instead > of having to fall back to old handling (which as mentioned above > is incomplete). Please let me know. > You're right, hopefully we can introduce it in the upstream dts for v4.14... So it does make sense to fix this up now, rather than live with the fallback forever. Can you ensure we get an "ack" from Vivek on this? Regards, Bjorn