Re: [PATCH 6/6] cgroup: update debug controller to print out thread mode information

Tejun Heo
2017-07-19T15:44:12Z

On Wed, Jul 19, 2017 at 11:41:09AM -0400, Waiman Long wrote:
> On 07/19/2017 11:31 AM, Tejun Heo wrote:
> > Hello,
> >
> > On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote:
> >>> + if (cgroup_is_thread_root(css->cgroup))
> >>> + seq_puts(seq, "[thread root]\n");
> >>> + else if (cgroup_is_threaded(css->cgroup))
> >>> + seq_puts(seq, "[threaded]\n");
> >> The cgroup status will not be needed anymore as you have introduced the
> >> cgroup.type control file that returns the proper information.
> > Ah, right, will drop this file.
> >
> > Thanks.
> >
> Oh, I am not saying that we should drop the whole patch. I just want to
> drop the above 4 line of codes as they are not needed.

lol, yeah, that's me mis-writing. I'm gonna drop only the duplicate
part.

Thanks.

--
tejun