* [PATCH] sound: fsl_dma: remove dma_object path member
@ 2017-07-18 21:43 Rob Herring
2017-07-19 3:12 ` Timur Tabi
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2017-07-18 21:43 UTC (permalink / raw)
To: Takashi Iwai, Mark Brown
Cc: linux-kernel, devicetree, Timur Tabi, Nicolin Chen, Xiubo Li,
Fabio Estevam, Liam Girdwood, Jaroslav Kysela, alsa-devel,
linuxppc-dev
dma_object.path is unused, so rather than fix it to work with DT
full_name changes, just remove it.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Timur Tabi <timur@tabi.org>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
---
sound/soc/fsl/fsl_dma.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index ccadefceeff2..b38dd328c783 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -63,7 +63,6 @@ struct dma_object {
struct ccsr_dma_channel __iomem *channel;
unsigned int irq;
bool assigned;
- char path[1];
};
/*
@@ -897,20 +896,19 @@ static int fsl_soc_dma_probe(struct platform_device *pdev)
ret = of_address_to_resource(ssi_np, 0, &res);
if (ret) {
- dev_err(&pdev->dev, "could not determine resources for %s\n",
- ssi_np->full_name);
+ dev_err(&pdev->dev, "could not determine resources for %pOF\n",
+ ssi_np);
of_node_put(ssi_np);
return ret;
}
- dma = kzalloc(sizeof(*dma) + strlen(np->full_name), GFP_KERNEL);
+ dma = kzalloc(sizeof(*dma), GFP_KERNEL);
if (!dma) {
dev_err(&pdev->dev, "could not allocate dma object\n");
of_node_put(ssi_np);
return -ENOMEM;
}
- strcpy(dma->path, np->full_name);
dma->dai.ops = &fsl_dma_ops;
dma->dai.pcm_new = fsl_dma_new;
dma->dai.pcm_free = fsl_dma_free_dma_buffers;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: fsl_dma: remove dma_object path member
2017-07-18 21:43 [PATCH] sound: fsl_dma: remove dma_object path member Rob Herring
@ 2017-07-19 3:12 ` Timur Tabi
0 siblings, 0 replies; 2+ messages in thread
From: Timur Tabi @ 2017-07-19 3:12 UTC (permalink / raw)
To: Rob Herring, Takashi Iwai, Mark Brown
Cc: linux-kernel, devicetree, Nicolin Chen, Xiubo Li, Fabio Estevam,
Liam Girdwood, Jaroslav Kysela, alsa-devel, linuxppc-dev
On 7/18/17 4:43 PM, Rob Herring wrote:
> - dev_err(&pdev->dev, "could not determine resources for %s\n",
> - ssi_np->full_name);
> + dev_err(&pdev->dev, "could not determine resources for %pOF\n",
> + ssi_np);
I think you meant to include this in the other patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-19 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-18 21:43 [PATCH] sound: fsl_dma: remove dma_object path member Rob Herring
2017-07-19 3:12 ` Timur Tabi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).