From: Ralf Baechle <ralf@linux-mips.org>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: "#4 . 11+" <stable@vger.kernel.org>,
John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header
Date: Wed, 19 Jul 2017 00:01:26 +0200 [thread overview]
Message-ID: <20170718220126.GA22091@linux-mips.org> (raw)
In-Reply-To: <1500384346-10527-1-git-send-email-harvey.hunt@imgtec.com>
On Tue, Jul 18, 2017 at 02:25:45PM +0100, Harvey Hunt wrote:
> Previously, <linux/module.h> was included before ralink_regs.h in all
> ralink files - leading to <linux/io.h> being implicitly included.
>
> After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
> uses of module.h") removed the inclusion of module.h from multiple
> places, some ralink platforms failed to build with the following error:
>
> In file included from arch/mips/ralink/mt7620.c:17:0:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_w32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit declaration of function ‘__raw_writel’ [-Werror=implicit-function-declaration]
> __raw_writel(val, rt_sysc_membase + reg);
> ^
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_r32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit declaration of function ‘__raw_readl’ [-Werror=implicit-function-declaration]
> return __raw_readl(rt_sysc_membase + reg);
>
> Fix this by including <linux/io.h>.
Looks sensible, applied. But I'm wondering why I don't see this in my
test builds.
Ralf
next prev parent reply other threads:[~2017-07-18 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 13:25 [PATCH 1/2] MIPS: ralink: Fix build error due to missing header Harvey Hunt
2017-07-18 13:25 ` [PATCH 2/2] MIPS: ralink: mt7620: Add " Harvey Hunt
2017-07-18 22:05 ` Ralf Baechle
2017-07-18 22:01 ` Ralf Baechle [this message]
2017-07-19 10:55 ` [PATCH 1/2] MIPS: ralink: Fix build error due to " Harvey Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718220126.GA22091@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=harvey.hunt@imgtec.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).