From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbdGRUNS (ORCPT ); Tue, 18 Jul 2017 16:13:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdGRUNQ (ORCPT ); Tue, 18 Jul 2017 16:13:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1AA3F7A161 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1AA3F7A161 Date: Tue, 18 Jul 2017 23:13:15 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/5] refine virtio-net XDP Message-ID: <20170718230748-mutt-send-email-mst@kernel.org> References: <1500295441-19339-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500295441-19339-1-git-send-email-jasowang@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 18 Jul 2017 20:13:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote: > Hi: > > This series brings two optimizations for virtio-net XDP: > > - avoid reset during XDP set > - turn off offloads on demand I'm glad to see this take shape - this can be extended to optimize virtnet_get_headroom so we don't waste room if adjust_head is enabled. I see a couple of issues, responded to individual patches. > Please review. > > Thanks > > Jason Wang (5): > virtio_ring: allow to store zero as the ctx > virtio-net: pack headroom into ctx for mergeable buffer > virtio-net: switch to use new ctx API for small buffer > virtio-net: do not reset during XDP set > virtio-net: switch off offloads on demand if possible on XDP set > > drivers/net/virtio_net.c | 325 +++++++++++++++++++++++++------------------ > drivers/virtio/virtio_ring.c | 2 +- > 2 files changed, 194 insertions(+), 133 deletions(-) > > -- > 2.7.4