From: Peter Chen <hzpeterchen@gmail.com>
To: <frowand.list@gmail.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()
Date: Wed, 19 Jul 2017 09:51:48 +0800 [thread overview]
Message-ID: <20170719015147.GA26218@b29397-desktop> (raw)
In-Reply-To: <1500420688-11912-1-git-send-email-frowand.list@gmail.com>
On Tue, Jul 18, 2017 at 04:31:28PM -0700, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
> OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000
>
> The error will occur if the configuration is set to:
> CONFIG_OF_OVERLAY y
> CONFIG_OF_UNITTEST y
> CONFIG_OF_DYNAMIC y
> CONFIG_OF_RESOLVE y
>
> If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
> attempt to release a node that is still attached to the device tree.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 0bdfcdcbf7a5..bb626120296f 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
> if (ret)
> goto err_mux;
>
> - ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
> + ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
> if (ulpi_node) {
> phy_node = of_get_next_available_child(ulpi_node, NULL);
> ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
> --
Applied, thanks.
--
Best Regards,
Peter Chen
prev parent reply other threads:[~2017-07-19 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 23:31 [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get() frowand.list
2017-07-19 1:51 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719015147.GA26218@b29397-desktop \
--to=hzpeterchen@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).