public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, otubo@redhat.com,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	vkuznets@redhat.com
Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
Date: Wed, 19 Jul 2017 09:44:31 -0700	[thread overview]
Message-ID: <20170719094431.308c095b@xeon-e3> (raw)
In-Reply-To: <20170719131928.18209-1-mgamal@redhat.com>

On Wed, 19 Jul 2017 15:19:28 +0200
Mohammed Gamal <mgamal@redhat.com> wrote:

> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
> 
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 63c98bb..06d591c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
>  
>  		if (ip6->nexthdr == IPPROTO_TCP)
>  			return TRANSPORT_INFO_IPV6_TCP;
> -		else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> +		else if (ip6->nexthdr == IPPROTO_UDP)
>  			return TRANSPORT_INFO_IPV6_UDP;
>  	}
>  

Patch looks fine.
Network patches go through netdev@vger.kernel.org not linux driver mailing list.
I will add it to my next patch of patches that are going to netdev for net-next.

  parent reply	other threads:[~2017-07-19 16:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 13:19 [PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal
2017-07-19 15:19 ` Haiyang Zhang
2017-07-19 16:44 ` Stephen Hemminger [this message]
2017-07-19 17:48   ` Mohammed Gamal
2017-07-19 17:59     ` Stephen Hemminger
2017-07-19 18:52     ` Haiyang Zhang
2017-07-19 19:10     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719094431.308c095b@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgamal@redhat.com \
    --cc=otubo@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox