* [PATCH] netvsc: Remove redundant use of ipv6_hdr()
@ 2017-07-19 13:19 Mohammed Gamal
2017-07-19 15:19 ` Haiyang Zhang
2017-07-19 16:44 ` Stephen Hemminger
0 siblings, 2 replies; 7+ messages in thread
From: Mohammed Gamal @ 2017-07-19 13:19 UTC (permalink / raw)
To: kys, haiyangz, sthemmin
Cc: devel, linux-kernel, vkuznets, cavery, otubo, Mohammed Gamal
This condition already uses an object of type ipv6hdr in the line above.
Use the object directly instead of calling ipv6_hdr
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 63c98bb..06d591c 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
if (ip6->nexthdr == IPPROTO_TCP)
return TRANSPORT_INFO_IPV6_TCP;
- else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
+ else if (ip6->nexthdr == IPPROTO_UDP)
return TRANSPORT_INFO_IPV6_UDP;
}
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 13:19 [PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal
@ 2017-07-19 15:19 ` Haiyang Zhang
2017-07-19 16:44 ` Stephen Hemminger
1 sibling, 0 replies; 7+ messages in thread
From: Haiyang Zhang @ 2017-07-19 15:19 UTC (permalink / raw)
To: Mohammed Gamal, KY Srinivasan, Stephen Hemminger
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
vkuznets@redhat.com, cavery@redhat.com, otubo@redhat.com
> -----Original Message-----
> From: Mohammed Gamal [mailto:mgamal@redhat.com]
> Sent: Wednesday, July 19, 2017 9:19 AM
> To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>
> Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> vkuznets@redhat.com; cavery@redhat.com; otubo@redhat.com; Mohammed Gamal
> <mgamal@redhat.com>
> Subject: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
>
> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 13:19 [PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal
2017-07-19 15:19 ` Haiyang Zhang
@ 2017-07-19 16:44 ` Stephen Hemminger
2017-07-19 17:48 ` Mohammed Gamal
1 sibling, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2017-07-19 16:44 UTC (permalink / raw)
To: Mohammed Gamal
Cc: kys, haiyangz, sthemmin, otubo, linux-kernel, devel, vkuznets
On Wed, 19 Jul 2017 15:19:28 +0200
Mohammed Gamal <mgamal@redhat.com> wrote:
> This condition already uses an object of type ipv6hdr in the line above.
> Use the object directly instead of calling ipv6_hdr
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 63c98bb..06d591c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
>
> if (ip6->nexthdr == IPPROTO_TCP)
> return TRANSPORT_INFO_IPV6_TCP;
> - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> + else if (ip6->nexthdr == IPPROTO_UDP)
> return TRANSPORT_INFO_IPV6_UDP;
> }
>
Patch looks fine.
Network patches go through netdev@vger.kernel.org not linux driver mailing list.
I will add it to my next patch of patches that are going to netdev for net-next.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 16:44 ` Stephen Hemminger
@ 2017-07-19 17:48 ` Mohammed Gamal
2017-07-19 17:59 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mohammed Gamal @ 2017-07-19 17:48 UTC (permalink / raw)
To: Stephen Hemminger
Cc: kys, haiyangz, sthemmin, otubo, linux-kernel, devel, vkuznets
----- Original Message -----
> On Wed, 19 Jul 2017 15:19:28 +0200
> Mohammed Gamal <mgamal@redhat.com> wrote:
>
> > This condition already uses an object of type ipv6hdr in the line above.
> > Use the object directly instead of calling ipv6_hdr
> >
> > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > ---
> > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > b/drivers/net/hyperv/netvsc_drv.c
> > index 63c98bb..06d591c 100644
> > --- a/drivers/net/hyperv/netvsc_drv.c
> > +++ b/drivers/net/hyperv/netvsc_drv.c
> > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> >
> > if (ip6->nexthdr == IPPROTO_TCP)
> > return TRANSPORT_INFO_IPV6_TCP;
> > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > + else if (ip6->nexthdr == IPPROTO_UDP)
> > return TRANSPORT_INFO_IPV6_UDP;
> > }
> >
>
> Patch looks fine.
> Network patches go through netdev@vger.kernel.org not linux driver mailing
> list.
> I will add it to my next patch of patches that are going to netdev for
> net-next.
>
Thanks for the heads up. Will take that into consideration next time.
It's worth pointing out that MAINTAINERS points that files under
drivers/net/hyperv are to be sent to devel@linuxdriverproject.org.
Perhaps that should be updated.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 17:48 ` Mohammed Gamal
@ 2017-07-19 17:59 ` Stephen Hemminger
2017-07-19 18:52 ` Haiyang Zhang
2017-07-19 19:10 ` Dan Carpenter
2 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2017-07-19 17:59 UTC (permalink / raw)
To: Mohammed Gamal
Cc: kys, haiyangz, sthemmin, otubo, linux-kernel, devel, vkuznets
On Wed, 19 Jul 2017 13:48:03 -0400 (EDT)
Mohammed Gamal <mgamal@redhat.com> wrote:
> ----- Original Message -----
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal <mgamal@redhat.com> wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line above.
> > > Use the object directly instead of calling ipv6_hdr
> > >
> > > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > > ---
> > > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > > b/drivers/net/hyperv/netvsc_drv.c
> > > index 63c98bb..06d591c 100644
> > > --- a/drivers/net/hyperv/netvsc_drv.c
> > > +++ b/drivers/net/hyperv/netvsc_drv.c
> > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> > >
> > > if (ip6->nexthdr == IPPROTO_TCP)
> > > return TRANSPORT_INFO_IPV6_TCP;
> > > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > > + else if (ip6->nexthdr == IPPROTO_UDP)
> > > return TRANSPORT_INFO_IPV6_UDP;
> > > }
> > >
> >
> > Patch looks fine.
> > Network patches go through netdev@vger.kernel.org not linux driver mailing
> > list.
> > I will add it to my next patch of patches that are going to netdev for
> > net-next.
> >
> Thanks for the heads up. Will take that into consideration next time.
>
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to devel@linuxdriverproject.org.
> Perhaps that should be updated.
MAINTAINERS doesn't have a good way to handle dual sub-trees.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 17:48 ` Mohammed Gamal
2017-07-19 17:59 ` Stephen Hemminger
@ 2017-07-19 18:52 ` Haiyang Zhang
2017-07-19 19:10 ` Dan Carpenter
2 siblings, 0 replies; 7+ messages in thread
From: Haiyang Zhang @ 2017-07-19 18:52 UTC (permalink / raw)
To: Mohammed Gamal, Stephen Hemminger
Cc: KY Srinivasan, Stephen Hemminger, otubo@redhat.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
vkuznets@redhat.com
> -----Original Message-----
> From: Mohammed Gamal [mailto:mgamal@redhat.com]
> Sent: Wednesday, July 19, 2017 1:48 PM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> otubo@redhat.com; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; vkuznets@redhat.com
> Subject: Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
>
>
>
> ----- Original Message -----
> > On Wed, 19 Jul 2017 15:19:28 +0200
> > Mohammed Gamal <mgamal@redhat.com> wrote:
> >
> > > This condition already uses an object of type ipv6hdr in the line
> above.
> > > Use the object directly instead of calling ipv6_hdr
> > >
> > > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > > ---
> > > drivers/net/hyperv/netvsc_drv.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/hyperv/netvsc_drv.c
> > > b/drivers/net/hyperv/netvsc_drv.c
> > > index 63c98bb..06d591c 100644
> > > --- a/drivers/net/hyperv/netvsc_drv.c
> > > +++ b/drivers/net/hyperv/netvsc_drv.c
> > > @@ -339,7 +339,7 @@ static u32 net_checksum_info(struct sk_buff *skb)
> > >
> > > if (ip6->nexthdr == IPPROTO_TCP)
> > > return TRANSPORT_INFO_IPV6_TCP;
> > > - else if (ipv6_hdr(skb)->nexthdr == IPPROTO_UDP)
> > > + else if (ip6->nexthdr == IPPROTO_UDP)
> > > return TRANSPORT_INFO_IPV6_UDP;
> > > }
> > >
> >
> > Patch looks fine.
> > Network patches go through netdev@vger.kernel.org not linux driver
> mailing
> > list.
> > I will add it to my next patch of patches that are going to netdev for
> > net-next.
> >
> Thanks for the heads up. Will take that into consideration next time.
>
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to devel@linuxdriverproject.org.
> Perhaps that should be updated.
I will update devel@linuxdriverproject.org in MAINTAINERS to the new
mailing list name of the Linux driver project.
Thanks,
- Haiyang
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()
2017-07-19 17:48 ` Mohammed Gamal
2017-07-19 17:59 ` Stephen Hemminger
2017-07-19 18:52 ` Haiyang Zhang
@ 2017-07-19 19:10 ` Dan Carpenter
2 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2017-07-19 19:10 UTC (permalink / raw)
To: Mohammed Gamal
Cc: Stephen Hemminger, otubo, sthemmin, haiyangz, linux-kernel, devel,
vkuznets
On Wed, Jul 19, 2017 at 01:48:03PM -0400, Mohammed Gamal wrote:
> It's worth pointing out that MAINTAINERS points that files under
> drivers/net/hyperv are to be sent to devel@linuxdriverproject.org.
> Perhaps that should be updated.
get_maintainer.pl gives you both because drivers/net/ is netdev. Just
use the script.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-19 19:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19 13:19 [PATCH] netvsc: Remove redundant use of ipv6_hdr() Mohammed Gamal
2017-07-19 15:19 ` Haiyang Zhang
2017-07-19 16:44 ` Stephen Hemminger
2017-07-19 17:48 ` Mohammed Gamal
2017-07-19 17:59 ` Stephen Hemminger
2017-07-19 18:52 ` Haiyang Zhang
2017-07-19 19:10 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox