public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Piotr Gregor <piotrgregor@rsyncme.org>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] drivers: staging: comedi: Add ftrace support
Date: Wed, 19 Jul 2017 16:21:06 +0200	[thread overview]
Message-ID: <20170719142106.GA30753@kroah.com> (raw)
In-Reply-To: <20170719135724.3oqaeojico7dxyj5@debian1.home>

On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote:
> + * Id : Description
> + * 0	Enter the interrupt of amplc_dio200_common
> + * 1	Called from same ISR of amplc_dio200_common if IRQ is handled

That is a very device-specific tracepoint, do we really want each driver
to be able to set these up?

Why can't ftrace handle this type of thing instead?

thanks,

greg k-h

  reply	other threads:[~2017-07-19 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 13:57 [PATCH] drivers: staging: comedi: Add ftrace support Piotr Gregor
2017-07-19 14:21 ` Greg Kroah-Hartman [this message]
2017-07-19 15:28   ` Piotr Gregor
  -- strict thread matches above, loose matches on Subject: below --
2017-07-19 11:30 Piotr Gregor
2017-07-19 11:38 ` Greg Kroah-Hartman
2017-07-19 13:25 ` Dan Carpenter
2017-07-19 21:05   ` Piotr Gregor
2017-07-20  8:35     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719142106.GA30753@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piotrgregor@rsyncme.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox