From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785AbdGSPR2 (ORCPT ); Wed, 19 Jul 2017 11:17:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57588 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753499AbdGSPR1 (ORCPT ); Wed, 19 Jul 2017 11:17:27 -0400 Date: Wed, 19 Jul 2017 17:17:21 +0200 From: Greg KH To: Juergen Gross Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage Message-ID: <20170719151721.GA31932@kroah.com> References: <20170719125817.GD17776@kroah.com> <20170719144344.GA10632@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote: > On 19/07/17 16:43, Greg KH wrote: > > From: Greg Kroah-Hartman > > > > It's better to be explicit and use the DRIVER_ATTR_RW() and > > DRIVER_ATTR_RO() macros when defining a driver's sysfs file. > > > > Bonus is this fixes up a checkpatch.pl warning. > > > > This is part of a series to drop DRIVER_ATTR() from the tree entirely. > > > > Cc: Boris Ostrovsky > > Cc: Juergen Gross > > Signed-off-by: Greg Kroah-Hartman > > Reviewed-by: Juergen Gross > > I'll take this through the Xen tree, unless you want to use your tree. If I can take it through mine, then I could drop DRIVER_ATTR() from the whole tree for the next kernel release, which would be ideal. But if you want to take it, that's fine, I can wait another release, no rush. thanks, greg k-h